Conversation
Contributor
Author
|
Retest this please jenkins: PRB-generic-config-parser #11753 was not stable |
Contributor
|
🛟 Devin Lifeguard found 1 likely issues in this PR
@rlm2002 |
dgarske
requested changes
Jan 7, 2026
add WC_CALLOC_VAR_EX function, replace WC_ALLOC_VAR_EX in tests
Contributor
Author
|
Retest this please jenkins: PRB-generic-config-parser was not stable |
dgarske
approved these changes
Jan 8, 2026
douzzer
approved these changes
Jan 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
WC_CALLOC_VAR_EX()to allocatehmac_copyvariable in case the calls to functions beforewc_HmacCopy()error out. Before,ERROR_OUT()would attempt to free garbage data when jumping tooutlabel from functions beforewc_HmacCopy().Fixes CID 556176-556182: Uninitialized scalar variable
Testing
./configure --enable-all && make checkChecklist