Merged
Conversation
…t/test.c: * add WC_RNG_BANK_STATIC to WC_RNG_BANK_SUPPORT, supporting WOLFSSL_NO_MALLOC; * in random_bank_test(), fix gate around _NO_VECTOR_OPS sha256.sha_method test (WOLFSSL_SMALL_STACK_CACHE, and USE_INTEL_SPEEDUP not WC_HAVE_VECTOR_SPEEDUPS); * in definition of struct wc_rng_bank_inst, accommodate WOLFSSL_NO_ATOMICS builds; wolfssl/wolfcrypt/random.h: in definition of struct WC_RNG, add gate to avoid empty union in !HAVE_HASHDRBG configs.
…/wc_rng_free(rng2)/ in random_bank_test(); wolfcrypt/src/rng_bank.c: tweaks to silence benign Coverity CHECKED_RETURN.
This comment was marked as spam.
This comment was marked as spam.
Contributor
Author
|
retest this please |
dgarske
approved these changes
Jan 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wolfcrypt/src/rng_bank.c,wolfssl/wolfcrypt/rng_bank.h,wolfcrypt/test/test.c:add
WC_RNG_BANK_STATICtoWC_RNG_BANK_SUPPORT, supportingWOLFSSL_NO_MALLOC;in
random_bank_test(), fix gate around_NO_VECTOR_OPSsha256.sha_methodtest (WOLFSSL_SMALL_STACK_CACHE, andUSE_INTEL_SPEEDUPnotWC_HAVE_VECTOR_SPEEDUPS);in definition of
struct wc_rng_bank_inst, accommodateWOLFSSL_NO_ATOMICSbuilds;wolfssl/wolfcrypt/random.h: in definition ofstruct WC_RNG, add gate to avoid empty union in !HAVE_HASHDRBGconfigs..wolfssl_known_macro_extras: fix for lexical order.wolfcrypt/src/rng_bank.c: fixes for typography ands/wc_FreeRng(rng2)/wc_rng_free(rng2)/inrandom_bank_test();wolfcrypt/src/rng_bank.c: tweaks to silence benign CoverityCHECKED_RETURN.