hmac: add missing ForceZero for tmp, prk.#9890
Open
philljj wants to merge 1 commit intowolfSSL:masterfrom
Open
hmac: add missing ForceZero for tmp, prk.#9890philljj wants to merge 1 commit intowolfSSL:masterfrom
philljj wants to merge 1 commit intowolfSSL:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds explicit zeroization for temporary HKDF/HMAC buffers to reduce the chance of sensitive material remaining in memory.
Changes:
- Zeroize
tmpbefore freeing HMAC state inwolfSSL_GetHmacMaxSize. - Refactor HKDF wrapper flow to call
Expandonly on successfulExtractand always zeroizeprkbefore returning.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
Retest this please. |
1 similar comment
Contributor
Author
|
Retest this please. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
hmac: add missing ForceZero for tmp, prk.
Fixes F-384, F-385.