Skip to content

Enforce null compression in compression_methods list#9913

Merged
douzzer merged 2 commits intowolfSSL:masterfrom
julek-wolfssl:fenrir/365
Mar 7, 2026
Merged

Enforce null compression in compression_methods list#9913
douzzer merged 2 commits intowolfSSL:masterfrom
julek-wolfssl:fenrir/365

Conversation

@julek-wolfssl
Copy link
Member

F-365

@julek-wolfssl julek-wolfssl self-assigned this Mar 6, 2026
Copilot AI review requested due to automatic review settings March 6, 2026 15:57
@julek-wolfssl julek-wolfssl added the For This Release Release version 5.9.0 label Mar 6, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enforces that a TLS ClientHello compression_methods list includes the mandatory null compression method, and adds a regression test to verify the server rejects ClientHello messages that omit it.

Changes:

  • Add a new TLS 1.2 API test that injects a malformed ClientHello without null compression.
  • Update internal handshake parsing to fail with COMPRESSION_ERROR (and send illegal_parameter when enabled) when null is missing.
  • Register the new test in the TLS test suite declarations.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
tests/api/test_tls.h Adds prototype and registers the new TLS test in the macro list.
tests/api/test_tls.c Introduces a memio-based TLS 1.2 regression test for missing null compression.
src/internal.c Adds enforcement: reject ClientHello compression lists that omit null.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@julek-wolfssl julek-wolfssl changed the title Enforce null compression in compression_methods list` Enforce null compression in compression_methods list Mar 6, 2026
@douzzer douzzer added the Staged Staged for merge pending final test results and review label Mar 6, 2026
@douzzer douzzer merged commit 467f16f into wolfSSL:master Mar 7, 2026
451 of 452 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

For This Release Release version 5.9.0 Staged Staged for merge pending final test results and review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants