Enforce null compression in compression_methods list#9913
Merged
douzzer merged 2 commits intowolfSSL:masterfrom Mar 7, 2026
Merged
Enforce null compression in compression_methods list#9913douzzer merged 2 commits intowolfSSL:masterfrom
douzzer merged 2 commits intowolfSSL:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enforces that a TLS ClientHello compression_methods list includes the mandatory null compression method, and adds a regression test to verify the server rejects ClientHello messages that omit it.
Changes:
- Add a new TLS 1.2 API test that injects a malformed ClientHello without
nullcompression. - Update internal handshake parsing to fail with
COMPRESSION_ERROR(and sendillegal_parameterwhen enabled) whennullis missing. - Register the new test in the TLS test suite declarations.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/api/test_tls.h | Adds prototype and registers the new TLS test in the macro list. |
| tests/api/test_tls.c | Introduces a memio-based TLS 1.2 regression test for missing null compression. |
| src/internal.c | Adds enforcement: reject ClientHello compression lists that omit null. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
douzzer
approved these changes
Mar 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
F-365