Skip to content

Fix Sentry 1GDC/1GEB/1GAF/1G8Z: move Reader DB writes off main thread #22861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nbradbury merged 6 commits into from
May 18, 2026
Merged

Fix Sentry 1GDC/1GEB/1GAF/1G8Z: move Reader DB writes off main thread #22861

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
fbc301c
Fix Sentry JETPACK-ANDROID-1GDC/1GEB/1GAF/1G8Z: move Reader DB writes…
nbradbury May 13, 2026
0a5ec19
Merge remote-tracking branch 'origin/trunk' into fix/sentry-1gdc-read…
nbradbury May 15, 2026
a34ca92
Use applicationScope.launch instead of Thread for setTagLastUpdated
nbradbury May 18, 2026
24d7925
Use shared executor for Reader blog-info DB writes
nbradbury May 18, 2026
7d45a1c
Merge branch 'trunk' into fix/sentry-1gdc-reader-volley-db-writes
nbradbury May 18, 2026
ce271d0
Merge branch 'trunk' into fix/sentry-1gdc-reader-volley-db-writes
nbradbury May 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 17 additions & 6 deletions WordPress/src/main/java/org/wordpress/android/ui/reader/actions/ReaderBlogActions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
package org.wordpress.android.ui.reader.actions;

import android.os.Handler;
import android.os.Looper;
import android.text.TextUtils;
import android.util.Pair;

Expand Down Expand Up @@ -32,8 +34,15 @@

import java.net.HttpURLConnection;
import java.util.Map;
import java.util.concurrent.ExecutorService;
import java.util.concurrent.Executors;

public class ReaderBlogActions {
// Serial worker for Reader DB writes triggered from Volley response callbacks. Using a single
// shared executor avoids spawning a thread per response and lets SQLite writes queue naturally.
private static final ExecutorService DB_EXECUTOR = Executors.newSingleThreadExecutor();
private static final Handler MAIN_HANDLER = new Handler(Looper.getMainLooper());

public static class BlockedBlogResult {
public long blogId;
public long feedId;
Expand Down Expand Up @@ -456,12 +465,14 @@ private static void handleUpdateBlogInfoResponse(JSONObject jsonObject, UpdateBl
return;
}

ReaderBlog blogInfo = ReaderBlog.fromJson(jsonObject);
ReaderBlogTable.addOrUpdateBlog(blogInfo);

if (infoListener != null) {
infoListener.onResult(blogInfo);
}
final ReaderBlog blogInfo = ReaderBlog.fromJson(jsonObject);
// Move the INSERT OR REPLACE off the main thread; callers expect onResult on main.
DB_EXECUTOR.execute(() -> {
ReaderBlogTable.addOrUpdateBlog(blogInfo);
if (infoListener != null) {
MAIN_HANDLER.post(() -> infoListener.onResult(blogInfo));
}
});
}

/*
Expand Down
4 changes: 2 additions & 2 deletions WordPress/src/main/java/org/wordpress/android/ui/reader/repository/ReaderPostRepository.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ class ReaderPostRepository @Inject constructor(
if (updateAction == ReaderPostServiceStarter.UpdateAction.REQUEST_NEWER ||
updateAction == ReaderPostServiceStarter.UpdateAction.REQUEST_REFRESH
) {
ReaderTagTable.setTagLastUpdated(tag)
applicationScope.launch(ioDispatcher) { ReaderTagTable.setTagLastUpdated(tag) }
}
handleUpdatePostsResponse(tag, jsonObject, updateAction, resultListener)
}
Expand Down Expand Up @@ -352,7 +352,7 @@ class ReaderPostRepository @Inject constructor(
if (updateAction == ReaderPostServiceStarter.UpdateAction.REQUEST_NEWER ||
updateAction == ReaderPostServiceStarter.UpdateAction.REQUEST_REFRESH
) {
ReaderTagTable.setTagLastUpdated(tag)
applicationScope.launch(ioDispatcher) { ReaderTagTable.setTagLastUpdated(tag) }
}
handleUpdatePostsResponse(tag, jsonObject, updateAction, resultListener)
}
Expand Down
Loading