Fix Sentry 1G11/1GB0/1GAA/1GCH/1GP0/1GZV/1GN4: async Reader paging count query#22863
Merged
Conversation
…Reader paging count ReaderPostListFragment.dataRequestedListener.onRequestData was invoked by RecyclerView's GapWorker on the main thread and ran ReaderPostTable. getNumPostsWithTag/getNumPostsInFeed/getNumPostsInBlog synchronously. On a busy SQLite connection pool the count query parked long enough to trip the ANR threshold. Move the count queries to Dispatchers.IO inside viewLifecycleOwner.lifecycleScope.launch and only resume on main to fire the existing updatePosts* calls (which start the FluxC service and need the activity context). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Collaborator
Generated by 🚫 Danger |
Contributor
|
|
Contributor
|
|
Avoids a race where the count query uses one tag and the follow-up updatePostsWithTag uses a different one if the user switches tags while the IO read is in flight. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a cluster of Reader list ANRs where
ReaderPostListFragment.dataRequestedListener.onRequestDataran a SQLite count query on the main thread from RecyclerView'sGapWorker(prefetch path):ReaderPostTable.getNumPostsWithTag(16 users)When the SQLite connection pool was busy with concurrent Reader writes, the prefetch-driven count query parked on
acquireConnectionlong enough to exceed the ANR budget.Changes
onRequestDatanow runs insideviewLifecycleOwner.lifecycleScope.launch. The SQL count queries (getNumPostsWithTag,getNumPostsInFeed,getNumPostsInBlog) move towithContext(Dispatchers.IO); the resultingupdatePostsWithTag/updatePostsInCurrentBlogOrFeed/updatePostsInCurrentSearchcalls and theREADER_INFINITE_SCROLLtrack call run back on main, since they touchactivityand start a FluxC service.The early
if (isUpdating) returnshort-circuit is preserved to avoid scheduling redundant coroutines.Test plan