Skip to content

Reader: Add support for <br> tags in excerpt generator#25392

Open
kean wants to merge 5 commits intotrunkfrom
fix/summary-with-br-tags
Open

Reader: Add support for <br> tags in excerpt generator#25392
kean wants to merge 5 commits intotrunkfrom
fix/summary-with-br-tags

Conversation

@kean
Copy link
Contributor

@kean kean commented Mar 17, 2026

Fixes CMM-82: Reader incorrectly renders newlines in excerpts.

Prerequisite: #25400.

This PR is for excerpts generated on the client. In the case of the post from the issue, the lack of whitespaces is backed in on the server. I opened a separate issue for the Loop team. The client-side one should be considered fixed, which you can see in the unit tests.

@kean kean added this to the 26.8 milestone Mar 17, 2026
@kean kean added the Reader label Mar 17, 2026
@wpmobilebot
Copy link
Contributor

wpmobilebot commented Mar 17, 2026

App Icon📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress
ConfigurationRelease-Alpha
Build Number31623
VersionPR #25392
Bundle IDorg.wordpress.alpha
Commit0e16c02
Installation URL3qgfudhl8hm80
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Mar 17, 2026

App Icon📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack
ConfigurationRelease-Alpha
Build Number31623
VersionPR #25392
Bundle IDcom.jetpack.alpha
Commit0e16c02
Installation URL55qof6uvffjeo
Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

@wpmobilebot
Copy link
Contributor

wpmobilebot commented Mar 17, 2026

🤖 Build Failure Analysis

This build has failures. Claude has analyzed them - check the build annotations for details.

@kean
Copy link
Contributor Author

kean commented Mar 18, 2026

In order to use WordPressShared in WordPressKitModel, it looks like I first need to resolve some issues with ObjC headers and helper methods duplicated in WPKit:

Found the issue. Both WordPressSharedObjC and WordPressKitObjC have a public header named WPMapFilterReduce.h. Now that WordPressKitObjC transitively depends on WordPressSharedObjC (via WordPressKitModels → WordPressShared → WordPressSharedObjC), the compiler resolves #import "WPMapFilterReduce.h" to WordPressSharedObjC's version — which defines WPMapBlock/WPFilterBlock but not WPKitMapBlock/WPKitFilterBlock.

@kean kean force-pushed the fix/summary-with-br-tags branch from b390713 to c7c2052 Compare March 19, 2026 19:49
@kean kean requested a review from crazytonyli March 19, 2026 19:54
@kean kean marked this pull request as ready for review March 19, 2026 19:54
@kean kean force-pushed the fix/summary-with-br-tags branch from 218eb41 to 0e16c02 Compare March 19, 2026 19:56
@sonarqubecloud
Copy link

@crazytonyli
Copy link
Contributor

FYI, the unit tests job failed.

@wpmobilebot wpmobilebot modified the milestones: 26.8, 26.9 Mar 20, 2026
@wpmobilebot
Copy link
Contributor

Version 26.8 has now entered code-freeze, so the milestone of this PR has been updated to 26.9.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants