Avoid task delegates for background sessions#25774
Merged
Merged
Conversation
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 33125 | |
| Version | PR #25774 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 0c00b5f | |
| Installation URL | 382em8pcsorp8 |
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 33125 | |
| Version | PR #25774 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 0c00b5f | |
| Installation URL | 0s8ttpfebtep8 |
jkmassel
approved these changes
Jul 13, 2026
jkmassel
left a comment
jkmassel
left a comment
Contributor
There was a problem hiding this comment.
LGTM, but I left two nits for your consideration
|
|
||
| task.delegate = wpkURLSessionNotifyingDelegate | ||
| // Background tasks only support the delegate assigned to their session at creation time. | ||
| if configuration.identifier == nil, let delegate = wpkURLSessionNotifyingDelegate { |
Contributor
There was a problem hiding this comment.
nit: we use configuration.identifier == nil in a few different places in this file – WDYT about introducing isBackgroundSession to make it a bit more clear at the call site?
Contributor
There was a problem hiding this comment.
another nit – do we need to unwrap wpkURLSessionNotifyingDelegate? Assigning nil to task.delegate wouldn't cause problems, would it?
Contributor
Author
There was a problem hiding this comment.
Weirdly, it would crash.
Contributor
|
disabled auto-merge in case you want to address the nits. Feel free to merge if not |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I noticed this share extension crash in the App Store Connection crash reporter in Xcode.