App Size Metrics: add support for Android Universal APKs#365
Merged
AliSoftware merged 10 commits intotrunkfrom May 31, 2022
Merged
App Size Metrics: add support for Android Universal APKs#365AliSoftware merged 10 commits intotrunkfrom
AliSoftware merged 10 commits intotrunkfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This work is part of the App Metrics project [ref: paaHJt-37V-p2] and implements the fastlane actions necessary to send iOS and Android app size metrics [ref: paaHJt-3od-p2#comment-6098] to the App Metrics server.
What
This builds on top of #364 and adds support for including "Universal APKs" metrics for Android.
(I suggest to get #364 merged first before this #365, to keep the diffs of each PR separate and easier to review in isolation)
Why
This will mostly be useful if/when we want to send app size metrics for Installable Builds, which are build using
./gradlew assemble<app>JalapenoDebugand thus produce a single, Universal.apk— as opposed to an.aabbundle like we do for beta and release builds that we upload to the Play Store)How
universal_apk_pathparameter for theandroid_send_app_size_metricsactionaab_pathparameter is no longer mandatory, to allow the case where we only pass the universal APK but no.aab. It's still required to have at least one ofuniversal_apk_pathoraab_path(if not both) though."Optimized File Size"for R8-optimized APKs (i.e.file-sizeas reported byapkanalyzer, as opposed to the.apkfile size on disk).apkanalyzer", as opposed to "optimized for a specific device architecture", that latter being instead indicated by thesplit:metadata)To Test
*-app-size-metrics.jsonfiles in the "Artifacts" tab of the WPAndroid PR's CircleCI job look as expected.