-
Notifications
You must be signed in to change notification settings - Fork 287
Refactor controls js generation #3192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rzblue
wants to merge
1
commit into
wpilibsuite:main
Choose a base branch
from
rzblue:optimize-js-gen
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
rzblue
commented
Dec 3, 2025
- Only regenerate output when input changes. This fixes issues with autobuilders that trigger rebuilds on filesystem events
- Use logging api instead of print. This makes the extension obey sphinx's verbosity settings
- Use pathlib
- use snake_case
- Only regenerate output when input changes. This fixes issues with autobuilders that trigger rebuilds on filesystem events - Use logging api instead of print. This makes the extension obey sphinx's verbosity settings - Use pathlib - use snake_case
katzuv
reviewed
Dec 3, 2025
Comment on lines
+74
to
+100
| with OUTPUT_FILE.open("w") as outf: | ||
| for source_file in source_files: | ||
| with source_file.open("r") as source: | ||
| if not debugJS: | ||
| # Minify each file independently - again, low bar solution for now | ||
| minified = jsmin(source.read()) | ||
| outf.write(minified) | ||
| outf.write("\n") | ||
| else: | ||
| # Verbose, no minify, and add debug markers. | ||
| outf.write("\n\n\n") | ||
| outf.write( | ||
| "//*******************************************************\n" | ||
| ) | ||
| outf.write( | ||
| "//*******************************************************\n" | ||
| ) | ||
| outf.write("//** {}\n".format(source_file)) | ||
| outf.write( | ||
| "//*******************************************************\n" | ||
| ) | ||
| outf.write( | ||
| "//*******************************************************\n" | ||
| ) | ||
| outf.write("\n") | ||
| outf.write(source.read()) | ||
| outf.write("\n") |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| with OUTPUT_FILE.open("w") as outf: | |
| for source_file in source_files: | |
| with source_file.open("r") as source: | |
| if not debugJS: | |
| # Minify each file independently - again, low bar solution for now | |
| minified = jsmin(source.read()) | |
| outf.write(minified) | |
| outf.write("\n") | |
| else: | |
| # Verbose, no minify, and add debug markers. | |
| outf.write("\n\n\n") | |
| outf.write( | |
| "//*******************************************************\n" | |
| ) | |
| outf.write( | |
| "//*******************************************************\n" | |
| ) | |
| outf.write("//** {}\n".format(source_file)) | |
| outf.write( | |
| "//*******************************************************\n" | |
| ) | |
| outf.write( | |
| "//*******************************************************\n" | |
| ) | |
| outf.write("\n") | |
| outf.write(source.read()) | |
| outf.write("\n") | |
| output_text = "" | |
| for source_file in source_files: | |
| text = "" | |
| if not debugJS: | |
| # Minify each file independently - again, low bar solution for now | |
| minified = jsmin(source_file.read_text()) | |
| text += minified + "\n" | |
| continue | |
| # Verbose, no minify, and add debug markers. | |
| text = f"""\n\n\n | |
| //******************************************************* | |
| //******************************************************* | |
| //** {source_file} | |
| //******************************************************* | |
| //******************************************************* | |
| {source_file.read_text()} | |
| """ | |
| output_text += textwrap.dedent(indented_string) | |
| OUTPUT_FILE.write_text(output_text) |
Further testing with dedent is needed, but I think it's more concise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.