geotiff: forward photometric through VRT writer (#1861)#1864
Merged
Conversation
to_geotiff(..., '.vrt', photometric=...) used to drop the kwarg between _write_vrt_tiled and _write_single_tile; the per-tile TIFFs are now tagged with the requested PhotometricInterpretation.
Contributor
There was a problem hiding this comment.
Pull request overview
Forwards the photometric kwarg from to_geotiff through the VRT writer path so per-tile TIFFs honor the requested PhotometricInterpretation tag (fixes #1861).
Changes:
- Add
photometricparameter to_write_vrt_tiledand_write_single_tile, forwarding towrite(...). - Pass
photometricthrough theto_geotiff→_write_vrt_tileddispatch. - Add regression tests verifying
miniswhiteand defaultautoproduce the expected Photometric tag on per-tile TIFFs.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| xrspatial/geotiff/init.py | Thread photometric through VRT writer dispatch and per-tile write calls. |
| xrspatial/geotiff/tests/test_vrt_writer_photometric_1861.py | New regression tests asserting per-tile PhotometricInterpretation matches the request. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
to_geotiff(..., '.vrt', photometric=...)now forwards the kwarg into_write_vrt_tiled,_write_single_tile, and the underlyingwrite(...)call so per-tile TIFFs carry the requested PhotometricInterpretation tag.Test plan
photometric='miniswhite'produces tile TIFFs with PhotometricInterpretation = 0.photometric='auto'still produces PhotometricInterpretation = 1.