Skip to content

geotiff: fix CI regression where int-coord no-georef writes hit fail-closed guard #1968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brendancol wants to merge 1 commit into from
+11 −0
Closed

geotiff: fix CI regression where int-coord no-georef writes hit fail-closed guard #1968

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions xrspatial/geotiff/_coords.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,17 @@ def require_transform_for_georeferenced(
ydim = da.dims[-2]
xdim = da.dims[-1]
if xdim in da.coords and ydim in da.coords:
# Integer-dtype coords are the read-side no-georef sentinel
# (see #1949 + ``coords_to_transform``): the reader emits
# ``np.arange(N, dtype=np.int64)`` for files without GeoTIFF
# tags. Those callers are explicitly *not* requesting a
# georeferenced output, so the fail-closed guard must not fire
# on them. Mirrors the same short-circuit in
# ``coords_to_transform``.
x = da.coords[xdim].values
y = da.coords[ydim].values
if x.dtype.kind in ('i', 'u') or y.dtype.kind in ('i', 'u'):
return
raise ValueError(
f"Cannot infer GeoTIFF transform from a "
f"{tuple(da.sizes.values())} array with spatial coords on "
Expand Down
Loading