Skip to content

Fixes xarray skin() function argument ordering mismatch #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wienkers wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixes xarray skin() function argument ordering mismatch #91

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f1a45f
Fixes xarray skin() function argument ordering mismatch with apply_uf…
wienkers Aug 6, 2025
c9427ea
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Aug 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions source/aerobulk/flux.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,9 +309,9 @@ def skin(
hum_zt,
u_zu,
v_zu,
rad_sw,
rad_lw,
slp=101000.0,
rad_sw=None,
rad_lw=None,
algo="coare3p0",
zt=2,
zu=10,
Expand Down Expand Up @@ -378,8 +378,13 @@ def skin(

_check_algo(algo, VALID_ALGOS_SKIN)

sst, t_zt, hum_zt, u_zu, v_zu, rad_sw, rad_lw, slp = xr.broadcast(
sst, t_zt, hum_zt, u_zu, v_zu, rad_sw, rad_lw, slp
if rad_sw is None:
raise ValueError("rad_sw is required and cannot be None")
if rad_lw is None:
raise ValueError("rad_lw is required and cannot be None")

sst, t_zt, hum_zt, u_zu, v_zu, slp, rad_sw, rad_lw = xr.broadcast(
sst, t_zt, hum_zt, u_zu, v_zu, slp, rad_sw, rad_lw
)

if input_range_check:
Expand All @@ -396,9 +401,9 @@ def skin(
hum_zt,
u_zu,
v_zu,
slp,
rad_sw,
rad_lw,
slp,
input_core_dims=[()] * 8,
output_core_dims=[()] * 6,
dask="parallelized",
Expand Down