Skip to content

refactor(messages): delegate comment handling to /receiving-feedback skill#125

Merged
neekolas merged 1 commit intoxmtplabs:mainfrom
xmtp-coder-agent:fix/issue-124
Apr 23, 2026
Merged

refactor(messages): delegate comment handling to /receiving-feedback skill#125
neekolas merged 1 commit intoxmtplabs:mainfrom
xmtp-coder-agent:fix/issue-124

Conversation

@xmtp-coder-agent
Copy link
Copy Markdown
Collaborator

@xmtp-coder-agent xmtp-coder-agent commented Apr 23, 2026

Resolves #124

Summary

Replaces the verbose, multi-paragraph [INSTRUCTIONS] block inside formatPRCommentMessage and formatIssueCommentMessage (src/actions/messages.ts) with a single line:

Use the /receiving-feedback skill to handle the following comment.

The agent already owns that decision logic via its receiving-feedback skill, so keeping a duplicate copy in the message template forced both copies to be kept in sync. This delegates to the skill and keeps the message format clean.

Changes

  • src/actions/messages.ts — simplified [INSTRUCTIONS] block in both formatPRCommentMessage and formatIssueCommentMessage. formatFailedCheckMessage is untouched (out of scope).
  • src/actions/messages.test.ts — the two "reacts with 👍 for automated" tests now assert the new single-line directive is present and that the old wording (👍, automated) is gone. Header / delimiter / File: / body-content tests unchanged.
  • Public signatures and the surrounding message frame (headers, [INSTRUCTIONS] / [END INSTRUCTIONS] / [COMMENT] / [END COMMENT] delimiters, instructions-before-body ordering) are preserved, so call-sites in src/workflows/steps/comment.ts and comment.test.ts require no changes.

Test plan

  • npm run check (typecheck + lint + format + 401 vitest tests) passes
  • Reviewer confirms the new directive wording is what you want

Note

Replace detailed comment instructions with /receiving-feedback skill directive in PR and issue messages

Updates formatPRCommentMessage and formatIssueCommentMessage in messages.ts to replace multi-step guidance (including thumbs-up reactions and automated comment handling) with a single directive to use the /receiving-feedback skill. Tests in messages.test.ts are updated to match the new output.

Macroscope summarized c2f55a9.

…skill

Replace the multi-paragraph [INSTRUCTIONS] block in formatPRCommentMessage
and formatIssueCommentMessage with a single directive pointing the agent at
its /receiving-feedback skill. Keeps decision logic in one place (the skill)
instead of duplicated across the message template.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@neekolas neekolas marked this pull request as ready for review April 23, 2026 00:19
@neekolas neekolas merged commit ec574f6 into xmtplabs:main Apr 23, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Simplify [INSTRUCTIONS] block in messages.ts to use /receiving-feedback skill

2 participants