refactor(messages): delegate comment handling to /receiving-feedback skill#125
Merged
neekolas merged 1 commit intoxmtplabs:mainfrom Apr 23, 2026
Merged
Conversation
…skill Replace the multi-paragraph [INSTRUCTIONS] block in formatPRCommentMessage and formatIssueCommentMessage with a single directive pointing the agent at its /receiving-feedback skill. Keeps decision logic in one place (the skill) instead of duplicated across the message template. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
neekolas
approved these changes
Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #124
Summary
Replaces the verbose, multi-paragraph
[INSTRUCTIONS]block insideformatPRCommentMessageandformatIssueCommentMessage(src/actions/messages.ts) with a single line:The agent already owns that decision logic via its
receiving-feedbackskill, so keeping a duplicate copy in the message template forced both copies to be kept in sync. This delegates to the skill and keeps the message format clean.Changes
src/actions/messages.ts— simplified[INSTRUCTIONS]block in bothformatPRCommentMessageandformatIssueCommentMessage.formatFailedCheckMessageis untouched (out of scope).src/actions/messages.test.ts— the two "reacts with 👍 for automated" tests now assert the new single-line directive is present and that the old wording (👍,automated) is gone. Header / delimiter /File:/ body-content tests unchanged.[INSTRUCTIONS]/[END INSTRUCTIONS]/[COMMENT]/[END COMMENT]delimiters, instructions-before-body ordering) are preserved, so call-sites insrc/workflows/steps/comment.tsandcomment.test.tsrequire no changes.Test plan
npm run check(typecheck + lint + format + 401 vitest tests) passesNote
Replace detailed comment instructions with
/receiving-feedbackskill directive in PR and issue messagesUpdates
formatPRCommentMessageandformatIssueCommentMessagein messages.ts to replace multi-step guidance (including thumbs-up reactions and automated comment handling) with a single directive to use the/receiving-feedbackskill. Tests in messages.test.ts are updated to match the new output.Macroscope summarized c2f55a9.