Fix/iOS value alignment#202
Open
mmng-a wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connection with issue(s)
No related issues.
This PR is based on #201 as the base branch.
Testing and Review Notes
This PR updates the iOS value layout for
SettingsTilewhenvalueis shown.In the iOS example screen, the most visible changes are:
Commonsection (Language,Environment,Platform) now show their values clearly right-alignedEmailrow in theAccountsection now shows a long value and truncates it with ellipsis correctlyBefore this change, the
Emailvalue was not shown on iOS in this example. After this change, it is shown and truncated correctly when long.Review steps:
example/.Commonsection, confirm that the values forLanguage,Environment, andPlatformare visually right-aligned.Accountsection, confirm that theEmailrow displays the value on iOS.Screenshots or Videos
Before and after screenshots are attached for the iOS example screen.
Please compare:
Language,Environment, andPlatformEmailvalue being displayed and truncated with ellipsisTo Do