Revert "fix: make xarray downstream tests work"#4047
Open
d-v-b wants to merge 3 commits into
Open
Conversation
This reverts commit b9d3964.
With no committed pixi.lock in pydata/xarray, setup-pixi's bare `pixi install` solves every environment in the manifest, including `mypy-upstream`, which sources numcodecs from git and fails under newer pixi with `meson-python: error: Unknown option "pixi-conda-environment"` during the solve — before any test runs. Setting `environments: test-py313` makes setup-pixi run `pixi install -e test-py313`, which never solves that environment. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
pixi has no committed lockfile in pydata/xarray, so `pixi install` solves the entire manifest regardless of `-e <env>` — including the `mypy-upstream` environment, which sources numcodecs from git and fails to build under newer pixi with `meson-python: error: Unknown option "pixi-conda-environment"`. The job died at environment setup before any test ran, and the per-environment flag (the previously reverted approach) does not avoid the failing solve. Install xarray with uv from its checkout instead — the `dev` dependency group for pytest tooling plus the `io`/`parallel`/`accel` extras for the zarr-relevant backends — then override zarr with the branch build. Tests needing an uninstalled backend skip via xarray's `requires_*` markers. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #4043. That change didn't actually fix the problem, because the downstream tests did not run, because evidently they are not triggered by adding the "Downstream" label. This PR will actually fix the underlying issue, once I get the downstream tests running on this branch.