Fix of #4237 : 'ValueError: Input array must be contiguous' when *cas… - #4238
Open
raphaeljolivet wants to merge 9 commits into
Conversation
github-actions
Bot
added
the
needs release notes
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4238 +/- ##
=======================================
Coverage 94.00% 94.00%
=======================================
Files 91 91
Lines 12795 12795
=======================================
Hits 12028 12028
Misses 767 767
🚀 New features to boost your workflow:
|
Use np.ascontiguousarray before calling cast-value-rs, and add regression tests for cast_value + transpose filter orderings. Fixes zarr-developers#4237
raphaeljolivet
force-pushed
the
bugfix/4237-cast-value-transpose-input-aray-should-be-contiguous
branch
from
August 5, 2026 11:06
212fd4a to
f8564b1
Compare
d-v-b
reviewed
Aug 5, 2026
| arr = chunk_array.as_ndarray_like() | ||
| target_native = self.dtype.to_native_dtype() | ||
|
|
||
| result = self._do_cast( |
Contributor
There was a problem hiding this comment.
can you move the fix into _do_cast?
d-v-b
reviewed
Aug 5, 2026
|
|
||
| import numpy as np | ||
| import pytest | ||
| from numpy.ma.testutils import assert_array_equal |
Contributor
There was a problem hiding this comment.
Suggested change
| from numpy.ma.testutils import assert_array_equal | |
| from numpy.testing import assert_array_equal |
d-v-b
reviewed
Aug 5, 2026
| ] | ||
| ) | ||
|
|
||
| # Write should be ok |
Contributor
There was a problem hiding this comment.
not sure we need these comments -- the entire test should pass, right?
Contributor
|
thank you for this! can you add a release note? |
github-actions
Bot
removed
the
needs release notes
…should-be-contiguous
…should-be-contiguous
d-v-b
reviewed
Aug 10, 2026
d-v-b
reviewed
Aug 10, 2026
| Transpose codec produces non-contiguous arrays. | ||
| Ensure cast_value makes them contiguous before processing. | ||
| """ | ||
| data = np.arange(20, dtype=np.float32).reshape(5, 2, 2) |
Contributor
There was a problem hiding this comment.
can we parametrize this test over the shape of the array? Specifically, we need to test 0-dimensional arrays, because I think the current fix will not work for 0-dim arrays, and we need to do np.asarray(order="C") instead of np.ascontiguousarray.
Assisted-by: ClaudeCode:claude-opus-5
…should-be-contiguous
Contributor
|
@raphaeljolivet can you check the failing example against the branch in this PR: #4260? If that fixes the bug, then maybe this PR can simplify to just adding tests? |
…should-be-contiguous
d-v-b
pushed a commit
to d-v-b/zarr-python
that referenced
this pull request
Aug 13, 2026
Regression test for zarr-developers#4237: a cast_value codec on either side of a transpose codec must round-trip, because transpose hands the next codec a non-row-major view. Imported unchanged from zarr-developers#4238, where this test was written. The np.ascontiguousarray workaround that accompanied it there is deliberately left out: cast-value-rs 0.4.2 normalizes layout itself, and the workaround promotes 0-d arrays to shape (1,), breaking 0-d arrays. Co-authored-by: Raphael Jolivet <raphael.jolivet@minesparis.psl.eu> Assisted-by: ClaudeCode:claude-fable-5
d-v-b
added a commit
that referenced
this pull request
Aug 13, 2026
* deps: bump cast-value.rs to >= 0.4.2 * deps: update uv.lock for cast-value-rs >= 0.4.2 The pyproject floor alone left uv.lock pinning 0.4.0, so any lock-honoring install (uv sync --locked/--frozen) kept the version that silently transposes non-row-major input. Assisted-by: ClaudeCode:claude-fable-5 * fix(cast_value): enforce the cast-value-rs floor at runtime The pyproject floor only binds installs that go through the zarr[cast-value-rs] extra. An environment that already has an older cast-value-rs installed kept silently corrupting non-row-major input after upgrading zarr, which is the failure this floor exists to stop. Check the installed version at import and raise from _do_cast, so the error surfaces when the codec is used rather than breaking `import zarr` for everyone else. A backend without distribution metadata (a `maturin develop` build) has no version to compare and is left alone. Assisted-by: ClaudeCode:claude-fable-5 * test(cast_value): cover cast_value next to the transpose codec Regression test for #4237: a cast_value codec on either side of a transpose codec must round-trip, because transpose hands the next codec a non-row-major view. Imported unchanged from #4238, where this test was written. The np.ascontiguousarray workaround that accompanied it there is deliberately left out: cast-value-rs 0.4.2 normalizes layout itself, and the workaround promotes 0-d arrays to shape (1,), breaking 0-d arrays. Co-authored-by: Raphael Jolivet <raphael.jolivet@minesparis.psl.eu> Assisted-by: ClaudeCode:claude-fable-5 --------- Co-authored-by: Raphael Jolivet <contact@raphael-jolivet.name> Co-authored-by: Raphael Jolivet <raphael.jolivet@minesparis.psl.eu>
Contributor
|
sorry for the churn @raphaeljolivet but I think some of these changes are superseded by #4260, please have a look |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix of #4237 with unit test.