-
Notifications
You must be signed in to change notification settings - Fork 8
[MFD-13002] Add customised colours API to demo app #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi Ian, |
I can try but I will have to make the Zendesk initialisation a global instance to inject the default factory. Let me try this. |
…sing a new card section
Done. I added a |
| import zendesk.logger.Logger | ||
| import javax.inject.Inject | ||
|
|
||
| class ZendeskManager @Inject constructor() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we don't need Hilt for this demo. We can simply wrap ZendeskManager in object and keep the demo free from any specific API constraints.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah you're right. It's overly complicating it. I can remove it.
| <string name="conversation_card_description">Displays the conversation screen for the initial conversation created for your user. A user and a new conversation will automatically be created if they don\'t exist. Ensure you have previously initialized the Zendesk SDK.</string> | ||
| <string name="conversation_button">Show conversation</string> | ||
|
|
||
| <string name="colors_api_card_title">Change the theme color</string> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To avoid confusion, maybe we should specify that we're setting custom colors with this section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can add that in the card description.
Uh oh!
There was an error while loading. Please reload this page.