You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is my first time touching Zig and I did use AI to help me but I've reviewed every line so if there's any mistakes please let me know. I'm not trying to submit AI slop.
Overview
Bump the repo to a newer version of Zig. I've installed 0.17.0-dev.644+3de725074 which was the latest at the time.
All builds, benches and tests pass locally.
Changes
CI
Bump the version from 0.15.2 to 0.17.0
.gitignore
add zig-pkg/
API changes on std
mainly using std.Io.package now but some places remain unchanged
lots of passing around of std.io
Allocators
GeneralPurposeAllocator has changed to SafeAllocator
imports
change from @cImport to @import("zlib");
updates build.zig api
build.zig.zon
new hashes and pinned urls
python client
Init a new client for each test to prevent crashes since we do not handle non-data frames
Strangely enough version 0.16.0 and older had exact versions but with 17 it is using a specific dev build. I'm unsure how things are developed for zig (e.g. if 17 is stable then they use the semantic version instead of dev) but I could pin it to one of the specified versions here but that is a bad practice and we'd need to update it to semantic versions asap.
I guess I need more context on how zig is developed and what the correct approach is here.
Strangely enough version 0.16.0 and older had exact versions but with 17 it is using a specific dev build. I'm unsure how things are developed for zig (e.g. if 17 is stable then they use the semantic version instead of dev) but I could pin it to one of the specified versions here but that is a bad practice and we'd need to update it to semantic versions asap.
I guess I need more context on how zig is developed and what the correct approach is here.
PR is sitting for weeks. Can we discuss this so it can be completed and merged or close it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disclaimer
This is my first time touching Zig and I did use AI to help me but I've reviewed every line so if there's any mistakes please let me know. I'm not trying to submit AI slop.
Overview
Bump the repo to a newer version of Zig. I've installed
0.17.0-dev.644+3de725074which was the latest at the time.All builds, benches and tests pass locally.
Changes
0.15.2to0.17.0zig-pkg/stdstd.Io.packagenow but some places remain unchangedstd.ioGeneralPurposeAllocatorhas changed toSafeAllocator@cImportto@import("zlib");build.zigapibuild.zig.zondebugtostdoutfor printing