Skip to content

Increase startup reset wait to 2 seconds#714

Merged
puddly merged 1 commit intozigpy:devfrom
agners:bump-network-reset-delay-to-2
Apr 28, 2026
Merged

Increase startup reset wait to 2 seconds#714
puddly merged 1 commit intozigpy:devfrom
agners:bump-network-reset-delay-to-2

Conversation

@agners
Copy link
Copy Markdown
Contributor

@agners agners commented Apr 28, 2026

When connecting over a TCP serial socket (e.g. the silabs-multiprotocol add-on), the NCP reset frame can take ~1.5s to arrive after the remote reuses the socket from a previous instance. The 1s wait causes a spurious retry on every startup; bumping to 2s lets the reset land within the first attempt.

When connecting over a TCP serial socket (e.g. the silabs-multiprotocol
add-on), the NCP reset frame can take ~1.5s to arrive after the remote
reuses the socket from a previous instance. The 1s wait causes a
spurious retry on every startup; bumping to 2s lets the reset land
within the first attempt.
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.54%. Comparing base (0d5b1b7) to head (297bf40).
⚠️ Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #714   +/-   ##
=======================================
  Coverage   99.54%   99.54%           
=======================================
  Files          61       61           
  Lines        4147     4147           
=======================================
  Hits         4128     4128           
  Misses         19       19           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@puddly puddly merged commit 4b97a6d into zigpy:dev Apr 28, 2026
12 checks passed
@agners
Copy link
Copy Markdown
Contributor Author

agners commented Apr 28, 2026

I've also noticed that you've experimented with 2s as well in #485 (see f2b9616). It does work with 1s every now and then (maybe 1 out of 10 attempts), but 2s makes it really reliable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants