Bump zigpy to 1.3.0 for serialx dependency#166
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #166 +/- ##
==========================================
- Coverage 46.46% 46.46% -0.01%
==========================================
Files 8 8
Lines 1302 1300 -2
==========================================
- Hits 605 604 -1
+ Misses 697 696 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
puddly
commented
Apr 20, 2026
| LOGGER.info("ZiGate found at %s", port) | ||
| else: | ||
| devices = list(serial.tools.list_ports.grep("067b:2303|CP2102")) | ||
| devices = [p for p in ports if re.search(r"067b:2303|CP2102", p.product or "")] |
Collaborator
Author
There was a problem hiding this comment.
I don't think discover_port is used anywhere so this shouldn't really matter. We're going to be deprecating this library anyways, I'd rather not spend much time fixing dead code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to zigpy/zigpy-znp#271.