Skip to content

print packet when ZDO packet deserialize fails#259

Merged
puddly merged 4 commits intozigpy:devfrom
pipiche38:dev
Apr 13, 2026
Merged

print packet when ZDO packet deserialize fails#259
puddly merged 4 commits intozigpy:devfrom
pipiche38:dev

Conversation

@pipiche38
Copy link
Copy Markdown
Contributor

When there is a on_zdo_message deserialize issue, it would be great to get the packet printed in order to get more information.
Especially having the 2 bytes of the message will indicate the status.

@puddly
Copy link
Copy Markdown
Collaborator

puddly commented Dec 8, 2024

Keep in mind that these deserialization failures are entirely inconsequential, Z-Stack does its own processing of ZDO and we haven't created handlers for all of the possible ways the ZDO commands can be parsed by Z-Stack. This is because we don't actually care about these and zigpy does its own processing on the raw packet. We just can't stop Z-Stack from sending its own commands as well.

I think you should just change warning to debug, it's not really a problem.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.46%. Comparing base (ed9a268) to head (25ed819).
⚠️ Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #259   +/-   ##
=======================================
  Coverage   98.46%   98.46%           
=======================================
  Files          43       43           
  Lines        3588     3588           
=======================================
  Hits         3533     3533           
  Misses         55       55           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@puddly puddly merged commit 5d7931b into zigpy:dev Apr 13, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants