Fix modified_date when zipping #930
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 28, 2025
nmoinvaz
approved these changes
Dec 1, 2025
Member
nmoinvaz
left a comment
nmoinvaz
left a comment
There was a problem hiding this comment.
This looks like it might work, we should perhaps wait for confirmation it fixes it?
Collaborator
Author
|
Yes, please wait for confirmation from @claraSophos or until I figure out a unit test that asserts that this is a clear improvement. I'll try to write one next weekend. In the mean time, feel free to help solving the Windows GitHub actions, Nathan. |
|
Hey, thank you for your quick response! Have tested this fix and can confirm it has fixed the issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an experimental attempt to fix #921 by reverting one of the lines modified by 7df56f7.
This fix is untested on my end, and purely based on code review.