Conversation
schneems
force-pushed
the
schneems/github-ci
branch
from
71ab25d to
27dc464
Compare
The test already verifies correct behavior via WebMock:
stub_request(:get, url).with(basic_auth: [...])
If set_auth_from_token! incorrectly runs, it overwrites the
Authorization header with "token ...", which won't match the
basic_auth expectation and WebMock rejects the request.
Originally added in 39f2d9e.
schneems
force-pushed
the
schneems/github-ci
branch
from
27dc464 to
a545c46
Compare
Member
Author
|
GHA is down and the build is green: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.