Open
Conversation
HMS17
requested review from
a team,
davedrp,
mlm483 and
nickpalladino
and removed request for
a team,
davedrp and
mlm483
| return false; | ||
| } | ||
|
|
||
| // Error conditions: |
Member
There was a problem hiding this comment.
Changing this to silently ignore pedigree conflicts instead of rejecting conflicting updates seems like it could be misleading to the user. Was there a reason for removing this?
| if (femaleParentFound) { | ||
| brAPIGermplasm.putAdditionalInfoItem(BrAPIAdditionalInfoFields.GERMPLASM_FEMALE_PARENT_GID, femaleParent.getAccessionNumber()); | ||
| //entry number no longer needed for figuring out parentage, can remove (since same germplasm can have different entry numbers across multiple lists) | ||
| brAPIGermplasm.putAdditionalInfoItem(BrAPIAdditionalInfoFields.GERMPLASM_FEMALE_PARENT_ENTRY_NO, null); |
Member
There was a problem hiding this comment.
I saw the comment in the PR description about these still showing up without a migration for old records. Is that something we need a card for?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Story: BI-2751 - Germplasm entry number weirdness
Changes to processing germplasm import to match user expectations of behavior.
NOTE that the import preview not containing entry numbers will only work for germplasm created after this change, a migration would be needed to remove parental entry numbers from additional info of existing germplasm
NOTE germplasm name in the upload file must be correct for error behavior to work properly, making logic solely dependent on accession no will be work of future card
Dependencies
bi-web:develop
Testing
Create new program, ensure test cases in linked card now pass
Checklist: