Skip to content

Conversation

@brettlangdon
Copy link
Member

Mostly seems like 5 seconds wasn't long enough in some cases, but I also added a retry policy in case the process exits early.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@brettlangdon brettlangdon requested a review from a team as a code owner July 14, 2025 18:09
@brettlangdon brettlangdon added the changelog/no-changelog A changelog entry is not required for this PR. label Jul 14, 2025
@github-actions
Copy link
Contributor

CODEOWNERS have been resolved as:

tests/profiling_v2/test_gunicorn.py                                     @DataDog/profiling-python

@github-actions
Copy link
Contributor

github-actions bot commented Jul 14, 2025

Bootstrap import analysis

Comparison of import times between this PR and base.

Summary

The average import time from this PR is: 275 ± 2 ms.

The average import time from base is: 281 ± 5 ms.

The import time difference between this PR and base is: -5.4 ± 0.2 ms.

Import time breakdown

The following import paths have shrunk:

ddtrace.auto 2.310 ms (0.84%)
ddtrace.bootstrap.sitecustomize 1.608 ms (0.58%)
ddtrace.bootstrap.preload 1.608 ms (0.58%)
ddtrace.internal.remoteconfig.client 0.710 ms (0.26%)
ddtrace 0.701 ms (0.25%)
ddtrace.internal._unpatched 0.034 ms (0.01%)
json 0.034 ms (0.01%)
json.decoder 0.034 ms (0.01%)
re 0.034 ms (0.01%)
enum 0.034 ms (0.01%)
types 0.034 ms (0.01%)
ddtrace.settings._config 0.015 ms (0.01%)
ddtrace.internal.schema 0.015 ms (0.01%)

@brettlangdon
Copy link
Member Author

hmm... maybe nvm, it still failed with the time.sleep(10).... all profiling jobs did pass for me on one run through, so I thought it was working...

@pr-commenter
Copy link

pr-commenter bot commented Jul 14, 2025

Benchmarks

Benchmark execution time: 2025-07-14 19:42:37

Comparing candidate commit 2258ce4 in PR branch brettlangdon/debug.profile.failure with baseline commit b4bdef9 in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 548 metrics, 2 unstable metrics.

@brettlangdon
Copy link
Member Author

#14014 seems better approach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog A changelog entry is not required for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants