Skip to content

ci: improve stability of gunicorn profiling tests #13990

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
brettlangdon wants to merge 4 commits into from
Closed

ci: improve stability of gunicorn profiling tests #13990

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ebdf500
ci: improve robustness of starting test gunicorn process
brettlangdon Jul 14, 2025
d54df3f
go back to a static sleep
brettlangdon Jul 14, 2025
3f2162f
remove unused helper
brettlangdon Jul 14, 2025
2258ce4
Merge branch 'main' into brettlangdon/debug.profile.failure
brettlangdon Jul 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions tests/profiling_v2/test_gunicorn.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,11 +69,22 @@ def _test_gunicorn(gunicorn, tmp_path, monkeypatch, *args):

debug_print("Creating gunicorn workers")
# DEV: We only start 1 worker to simplify the test
proc = gunicorn("-w", "1", *args)
# Wait for the workers to start
time.sleep(5)
for i in range(5):
proc = gunicorn("-w", "1", *args)

if proc.poll() is not None:
# Wait for the workers to start
time.sleep(10)

if proc.poll() is not None:
debug_print(f"Gunicorn process exited prematurely (return code: {proc.returncode}), retrying ({i + 1}/5)")
debug_print(f"Output from gunicorn process:\n{proc.stdout.read().decode()}")

# Try again
proc.kill()
continue

break
else:
pytest.fail("Gunicorn failed to start")

debug_print("Making request to gunicorn server")
Expand Down
Loading