Skip to content

Replace FullscreenLoadingIndicator with ActivityIndicator in SearchFiltersWorkspacePage #88744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Julesssss merged 2 commits into from
May 15, 2026
+9 −5
Merged

Replace FullscreenLoadingIndicator with ActivityIndicator in SearchFiltersWorkspacePage #88744

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b013749
Replace FullscreenLoadingIndicator with ActivityIndicator in SearchFi…
MelvinBot May 14, 2026
708290c
Simplify loading indicator View structure
MelvinBot May 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions src/pages/Search/SearchAdvancedFiltersPage/SearchFiltersWorkspacePage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import {emailSelector} from '@selectors/Session';
import React, {useCallback, useMemo, useState} from 'react';
import FullScreenLoadingIndicator from '@components/FullscreenLoadingIndicator';
import {View} from 'react-native';
import ActivityIndicator from '@components/ActivityIndicator';
import HeaderWithBackButton from '@components/HeaderWithBackButton';
import ScreenWrapper from '@components/ScreenWrapper';
import SearchFilterPageFooterButtons from '@components/Search/SearchFilterPageFooterButtons';
Expand All @@ -16,6 +17,7 @@ import type {WorkspaceListItem} from '@hooks/useWorkspaceList';
import useWorkspaceList from '@hooks/useWorkspaceList';
import {updateAdvancedFilters} from '@libs/actions/Search';
import Navigation from '@libs/Navigation/Navigation';
import CONST from '@src/CONST';
import ONYXKEYS from '@src/ONYXKEYS';
import ROUTES from '@src/ROUTES';
import isLoadingOnyxValue from '@src/types/utils/isLoadingOnyxValue';
Expand Down Expand Up @@ -105,10 +107,12 @@ function SearchFiltersWorkspacePage() {
}}
/>
{shouldShowLoadingIndicator ? (
<FullScreenLoadingIndicator
style={[styles.flex1, styles.pRelative]}
reasonAttributes={{context: 'SearchFiltersWorkspacePage', shouldShowLoadingIndicator}}
/>
<View style={[styles.flex1, styles.fullScreenLoading]}>
<ActivityIndicator
size={CONST.ACTIVITY_INDICATOR_SIZE.LARGE}
reasonAttributes={{context: 'SearchFiltersWorkspacePage', shouldShowLoadingIndicator}}
/>
</View>
) : (
<SelectionList<WorkspaceListItem>
data={data}
Expand Down
Loading