Add ownership check when giving a mutex#1454
Open
cookpate wants to merge 1 commit into
Open
Conversation
Disallow a held mutex from being given by another task, one that did not first take the mutex.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Add ownership check when giving a mutex
Description
In
xQueueGenericSend(fromxSemaphoreGive), when the queue's type is a mutex and that mutex is held, check its holder against the current task. Only allow the holding task to give the mutex.Test Steps
Scenario:
Task A and Task B with equal priorities, preemption enabled.
xSemaphoreTake) as Task A.xSemaphoreGive) as Task B.Without this change: Task B's
xSemaphoreGivesucceeds, the mutex is marked available, no longer taken by Task A.With this change: Task B's
xSeamphoreGivefails, the mutex remains taken, and it is still taken by Task A.Checklist:
Related Issue
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.