Skip to content

Add ownership check when giving a mutex #1454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cookpate wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add ownership check when giving a mutex #1454

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions queue.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -966,6 +966,20 @@ BaseType_t xQueueGenericSend( QueueHandle_t xQueue,
}
#endif

#if ( configUSE_MUTEXES == 1 )
{
/* If the queue is a mutex and is held, only the owner can give it. */
if( ( pxQueue->uxQueueType == queueQUEUE_IS_MUTEX ) &&
( pxQueue->u.xSemaphore.xMutexHolder != NULL ) &&
( pxQueue->u.xSemaphore.xMutexHolder != xTaskGetCurrentTaskHandle() ) )
{
traceRETURN_xQueueGenericSend( pdFAIL );

return pdFAIL;
}
}
#endif /* configUSE_MUTEXES */

for( ; ; )
{
taskENTER_CRITICAL();
Expand Down
Loading