Horsemanship#1138
Merged
Merged
Conversation
misode
added
the
submission
Member
Author
|
Ready for review, but needs textures and the pack.png before merging |
Contributor
|
Also probably want to update the README to not be shapeless portals copy 😅 |
runcows
reviewed
Nov 6, 2025
runcows
left a comment
runcows
left a comment
Contributor
There was a problem hiding this comment.
Partial Review. I didn't get through a lot of the functions, but I figured something is better than nothing :D
runcows
reviewed
Jan 22, 2026
| "heart_canisters": 15, | ||
| "helious_shamir": 69, | ||
| "holographic_tags": 94, | ||
| "horsemanship": 122, |
Contributor
There was a problem hiding this comment.
122 is taken by lavish livestock right now.
On main branch currently, "__next__": 124
Merged
misode
reviewed
Jan 25, 2026
misode
left a comment
misode
left a comment
Member
There was a problem hiding this comment.
I've just had a go testing this module in-game. I don't think this is mergeable right now.
- There doesn't seem to be any documentation of its features (wiki, readme, guidebook) meaning you have to read the code in order to know what to feed your horse.
- From some quick survival testing, it doesn't seem very fun? The initial speed of your horse is reduced a ton meaning you have to spend a lot of time just slowly riding your horse before it becomes useful.
- The level and stamina systems are not very visible, I had to cheat and look at the scoreboards to make any sense of it.
runhorse if you will
- removed Stamina mechanics - updated Guidebook entries - level 0 horses have higher stats (level 15 horses remain the same)
TheThanathor
force-pushed
the
horsemanship
branch
from
205ed14 to
856ada2
Compare
Bloo-dev
requested changes
Feb 22, 2026
Bloo-dev
left a comment
Bloo-dev
left a comment
Member
There was a problem hiding this comment.
Full review. I mostly found some minor format issues.
| # schedule from horse_processing/graze/start | ||
| # schedule from here | ||
|
|
||
| execute as @e[type=#gm4_horsemanship:trainable,tag=gm4_horse.grazing,nbt={EatingHaystack:0b}] at @s run function gm4_horsemanship:horse_processing/graze/complete |
Member
There was a problem hiding this comment.
So as I understand this you start a 1t clock the moment you detect a grazing horse until it stops grazing. I guess that is the only way to detect that, but the nbt check on a 20Hz is making me uncomfortable.
Member
|
This PR currently does not merge due to an issue with Guidebook: The clean way to fix this is to make PR which fixes the Guidebook logic. The dirty way is to just show a single, specific, horse armor in the horse wing recipe for now. |
Member
|
With #1276 merged this no longer errors. (once rebased) |
runcows
suggested changes
Mar 18, 2026
misode
reviewed
May 3, 2026
misode
approved these changes
Jun 14, 2026
misode
left a comment
misode
left a comment
Member
There was a problem hiding this comment.
Review changed were addressed. I did a final in-game test and things are working.
github-actions Bot
pushed a commit
that referenced
this pull request
Jun 14, 2026
* update old module to 1.21.5 * add swimming with rider * fix horse breeding, add varying scales * update horse training mechanics * add more sounds and particles * swap carrot to standard foods * update and simplify Horsemanship * update headers and reorganize folders * update horse flight * quick wing period fix * runcow's horse improvements runhorse if you will * add horse wing texture (WIP) * fix the wings! * oops missing tag * add advancement, image and website note * update to 1.21.11 * add translations * technically RP is not required rn * Backport mob_griefing gamerule * update Horsemanship - removed Stamina mechanics - updated Guidebook entries - level 0 horses have higher stats (level 15 horses remain the same) * update guidebook trigger * fix horse jumping * fix attribuite names * fix guidebook trigger, remove plugin change * resolve bloo's comments * fix last missing attribute * update cmd for 26.1 * update! added recipe advancement fixed horses losing wings mid flight added feather falling support fixed guidebook? horses now need to be moving to level up
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Level up your horses by using them to improve their health, speed and jump strength
Full module description will be added soon once the design is more finalized