Improve Guidebook Item Resolver#1276
Merged
Merged
Conversation
- supports non-vanilla tags
- supports {"id": "...", "required": false} entries in item tags (previously assumed strings)
(used for testing)
Bloo-dev
requested changes
Feb 28, 2026
Bloo-dev
left a comment
Bloo-dev
left a comment
Member
There was a problem hiding this comment.
I found some potential issues. These should never occur, but it would be nice to catch them and raise custom ValueErrors instead.
Co-authored-by: Bloo <git@bloo.boo>
Member
Author
|
Yeah, I agree the Guidebook script could use better error messages, but it might be better to do that in a separate PR that doesn't modify the actual result of a successful run |
Bloo-dev
approved these changes
Feb 28, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the following changes to the guidebook item tag resolution (getting a single item from an item tag)
Required for #1138 to build properly.