Skip to content

ENH: Add std::vector-like interface to VariableLengthVector #5682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
N-Dekker wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ENH: Add std::vector-like interface to VariableLengthVector #5682

N-Dekker wants to merge 1 commit into from
+365 −0

Conversation

@N-Dekker
Copy link
Contributor

@N-Dekker N-Dekker commented Dec 11, 2025

Added the following member functions:

 empty()
 size()
 at(size_type)
 front()
 back()
 data()
 begin()
 end()
 cbegin()
 cend()
 rbegin()
 rend()
 crbegin()
 crend()

As well as STL-style nested type aliases.

Aims to ease using VariableLengthVector in generic code.

@github-actions github-actions bot added type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots type:Enhancement Improvement of existing methods or implementation type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct area:Core Issues affecting the Core module labels Dec 11, 2025
dzenanz
dzenanz approved these changes Dec 11, 2025
View reviewed changes
Copy link
Member

@dzenanz dzenanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on a glance.

@N-Dekker N-Dekker force-pushed the Add-std-member-functions-to-VariableLengthVector branch from 7794a31 to d660d09 Compare December 11, 2025 20:32
@N-Dekker N-Dekker marked this pull request as ready for review December 12, 2025 10:15
@N-Dekker
Copy link
Contributor Author

N-Dekker commented Dec 12, 2025

/azp run ITK.Linux.Python

@N-Dekker
Copy link
Contributor Author

N-Dekker commented Dec 12, 2025

/azp run ITK.macOS.Python

N-Dekker
N-Dekker commented Dec 12, 2025
View reviewed changes
N-Dekker
N-Dekker commented Dec 12, 2025
View reviewed changes
@N-Dekker N-Dekker force-pushed the Add-std-member-functions-to-VariableLengthVector branch from d660d09 to 67f2c16 Compare December 13, 2025 20:17
@N-Dekker
ENH: Add std::vector-like interface to VariableLengthVector
122413d 
Added the following member functions:

     empty()
     size()
     at(size_type)
     front()
     back()
     data()
     begin()
     end()
     cbegin()
     cend()
     rbegin()
     rend()
     crbegin()
     crend()

As well as STL-style nested type aliases.

Aims to ease using `VariableLengthVector` in generic code.
@N-Dekker N-Dekker force-pushed the Add-std-member-functions-to-VariableLengthVector branch from 67f2c16 to 122413d Compare December 13, 2025 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hjmjohnson hjmjohnson hjmjohnson approved these changes

@dzenanz dzenanz dzenanz approved these changes

Assignees

No one assigned

Labels

area:Core Issues affecting the Core module type:Enhancement Improvement of existing methods or implementation type:Infrastructure Infrastructure/ecosystem related changes, such as CMake or buildbots type:Testing Ensure that the purpose of a class is met/the results on a wide set of test cases are correct

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@N-Dekker @hjmjohnson @dzenanz