tp: fix cppcheck invalidPrintfArgType_uint regressions#3985
Open
grandixximo wants to merge 1 commit intoLinuxCNC:masterfrom
Open
tp: fix cppcheck invalidPrintfArgType_uint regressions#3985grandixximo wants to merge 1 commit intoLinuxCNC:masterfrom
grandixximo wants to merge 1 commit intoLinuxCNC:masterfrom
Conversation
term_cond and motion_type are signed int (declared in tc_types.h); %u format specifier requires unsigned int. Restore %d that was previously fixed in commit b55ad81 but accidentally reverted by PR LinuxCNC#3683 (commit 402828c, stale-base rebase clobber). Added inline comments noting the field signedness so future rebases do not silently flip these specifiers back to %u. Fixes cppcheck warnings: emc/tp/tp.c:1709:9: invalidPrintfArgType_uint emc/tp/tp.c:1724:5: invalidPrintfArgType_uint (x2)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
%dformat specifiers in twotp_debug_printcalls insrc/emc/tp/tp.c.term_condandmotion_typeare signedint;%urequires unsigned.Fixes cppcheck warnings reported by @BsAtHome in #3683 (comment):
Test plan
make -j$(nproc)fromsrc/