Skip to content

tp: fix cppcheck invalidPrintfArgType_uint regressions #3985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
grandixximo wants to merge 1 commit into
base: master
Choose a base branch
from
+4 −2
Open

tp: fix cppcheck invalidPrintfArgType_uint regressions #3985

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/emc/tp/tp.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1706,7 +1706,8 @@ STATIC blend_type_t tpCheckBlendArcType(

//If exact stop, we don't compute the arc
if (prev_tc->term_cond != TC_TERM_COND_PARABOLIC) {
tp_debug_print("Wrong term cond = %u\n", prev_tc->term_cond);
// term_cond is signed int; use %d (cppcheck invalidPrintfArgType_uint)
tp_debug_print("Wrong term cond = %d\n", prev_tc->term_cond);
return BLEND_NONE;
}

Expand All @@ -1721,7 +1722,8 @@ STATIC blend_type_t tpCheckBlendArcType(
return BLEND_NONE;
}

tp_debug_print("Motion types: prev_tc = %u, tc = %u\n",
// motion_type is signed int; use %d (cppcheck invalidPrintfArgType_uint)
tp_debug_print("Motion types: prev_tc = %d, tc = %d\n",
prev_tc->motion_type,tc->motion_type);
//If not linear blends, we can't easily compute an arc
if ((prev_tc->motion_type == TC_LINEAR) && (tc->motion_type == TC_LINEAR)) {
Expand Down
Loading