Skip to content

feat(logger): [SDK-4939] adopt shared-module legacy purge (bump KMP submodule) #2693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
abdulraqeeb33 wants to merge 1 commit into from
Closed

feat(logger): [SDK-4939] adopt shared-module legacy purge (bump KMP submodule) #2693

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion OneSignal-KMP-SDK
Open in desktop
Submodule OneSignal-KMP-SDK updated 4 files
+13 −0 kmp/src/commonMain/kotlin/com/onesignal/logger/ILogFileStore.kt
+43 −3 kmp/src/commonMain/kotlin/com/onesignal/logger/crash/LogCrashUploader.kt
+52 −0 kmp/src/commonTest/kotlin/com/onesignal/logger/LogCrashTest.kt
+15 −0 kmp/src/commonTest/kotlin/com/onesignal/logger/TestFakes.kt
9 changes: 4 additions & 5 deletions ...al/core/src/main/java/com/onesignal/debug/internal/logging/logger/android/FileLogStore.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,15 +105,14 @@ internal class FileLogStore(
* `*.otlp` owned records are left untouched so failed / too-young uploads can
* still retry on the next launch.
*
* This is a host-side, belt-and-suspenders sweep invoked after the logger's
* crash-upload pass; it is intentionally not on the [ILogFileStore] contract so
* it requires no change to the shared KMP module. Idempotent and safe to call
* repeatedly.
* Implements the shared [ILogFileStore] contract: the KMP `LogCrashUploader`
* invokes this after its owned-record upload pass. The host also calls it as a
* belt-and-suspenders sweep. Idempotent and safe to call repeatedly.
*
* @return number of unrecognized entries deleted
*/
@Suppress("TooGenericExceptionCaught", "SwallowedException")
suspend fun deleteUnrecognizedEntries(): Int =
override suspend fun deleteUnrecognizedEntries(): Int =
withContext(Dispatchers.IO) {
try {
val foreign =
Expand Down
Loading