feat(logger): [SDK-4939] adopt shared-module legacy purge (bump KMP submodule) - #2693
Closed
abdulraqeeb33 wants to merge 1 commit into
Closed
feat(logger): [SDK-4939] adopt shared-module legacy purge (bump KMP submodule)#2693abdulraqeeb33 wants to merge 1 commit into
abdulraqeeb33 wants to merge 1 commit into
Conversation
…ubmodule) Bumps OneSignal-KMP-SDK to the commit that moves the legacy crash-file purge into the shared LogCrashUploader (OneSignal-KMP-SDK#8), so the cleanup runs in the shared module for every host (iOS included) rather than only host-side. FileLogStore.deleteUnrecognizedEntries now overrides the new ILogFileStore contract method, so it is invoked both by the KMP uploader's post-upload sweep and by the host belt-and-suspenders call in OneSignalCrashUploaderWrapper. Stacked on #2691. Submodule pin will be updated to the merged KMP SHA once OneSignal-KMP-SDK#8 lands. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
📊 Diff Coverage ReportDiff Coverage Report (Changed Lines Only)Gate: aggregate coverage on changed executable lines must be ≥ 80% (JaCoCo line data for lines touched in the diff). Changed Files Coverage✅ Coverage Check PassedAll checked files have no executable lines (or fully covered) |
4 tasks
Contributor
Author
|
Superseded by #2691 — host purge + KMP submodule adoption are now combined on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Linear: SDK-4939
Follow-up that moves the legacy crash-file purge from host-side into the shared KMP module, so it runs for every host (iOS included), not just Android.
OneSignal-KMP-SDKto the commit from OneSignal-KMP-SDK#8 (addsILogFileStore.deleteUnrecognizedEntries()to the contract + a post-upload purge inLogCrashUploader).FileLogStore.deleteUnrecognizedEntries()now overrides the contract method, so it's invoked both by the shared uploader's sweep and by the host belt-and-suspenders call.Stacking / merge order
Test plan
:OneSignal:core:compileDebugKotlin(compiles against bumped submodule):OneSignal:core:testDebugUnitTest --tests "*FileLogStoreTest*" --tests "*OneSignalCrashUploaderWrapperTest*":OneSignal:core:detekt+:OneSignal:core:spotlessKotlinCheck:kmp:testDebugUnitTest(10/10LogCrashTest) +:kmp:spotlessCheckMade with Cursor