Skip to content

[bsp][drives]fix(spi_config):修复H7的SPI6配置缺失问题#11633

Open
moment-NEW wants to merge 3 commits into
RT-Thread:masterfrom
moment-NEW:drv_spi_fix
Open

[bsp][drives]fix(spi_config):修复H7的SPI6配置缺失问题#11633
moment-NEW wants to merge 3 commits into
RT-Thread:masterfrom
moment-NEW:drv_spi_fix

Conversation

@moment-NEW

@moment-NEW moment-NEW commented Jul 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

拉取/合并请求描述：(PR description)

[

为什么提交这份PR (why to submit this PR)

为了解决issue #11626 中的H7 SPI6配置缺失问题

你的解决方案是什么 (what is your solution)

参考F4的配置，修改了spi_config.h

请提供验证的bsp和config (provide the config and bsp)

  • BSP:bsp\stm32\stm32h723-DM-MC02
  • .config:none
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用clang-format 源码格式化工具确保格式符合RT-Thread代码规范 This PR has been formatted with clang-format and complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown

👋 感谢您对 RT-Thread 的贡献！Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范，请在你的仓库中执行以下步骤运行代码格式化工作流（如果格式化CI运行失败）。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).

🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • 设置需排除的文件/目录（目录请以"/"结尾）
    Set files/directories to exclude (directories should end with "/")
  • 将目标分支设置为 \ Set the target branch to：drv_spi_fix
  • 设置PR number为 \ Set the PR number to：11633
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将自动推送至你的分支。
    The formatted code will be automatically pushed to your branch.

完成后，提交将自动更新至 drv_spi_fix 分支，关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the drv_spi_fix branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们，再次感谢您的贡献！💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@github-actions github-actions Bot added BSP: STM32 BSP related with ST/STM32 BSP labels Jul 17, 2026
@github-actions

github-actions Bot commented Jul 17, 2026 •
edited
Loading

Copy link
Copy Markdown

📌 Code Review Assignment

🏷️ Tag: bsp_stm32

Reviewers: @Liang1795 @hamburger-os @wdfk-prog

Changed Files (Click to expand)
  • bsp/stm32/libraries/HAL_Drivers/drivers/config/h7/spi_config.h

📊 Current Review Status (Last Updated: 2026-07-18 20:16 CST)

📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@github-actions

github-actions Bot commented Jul 17, 2026 •
edited
Loading

Copy link
Copy Markdown

MemBrowse Memory Report

No memory changes detected for:

@moment-NEW

moment-NEW commented Jul 17, 2026

Copy link
Copy Markdown
Contributor Author

关于验证，我在自己负责的DM-MC02 BSP上编写了一个WS2812驱动的软件包，经过本地测试SPI6正常工作。由于软件包还有格式和API问题，所以和BSP一起没有推上来，目前主仓库的BSP还不能直接验证这个改动。

@moment-NEW

moment-NEW commented Jul 17, 2026

Copy link
Copy Markdown
Contributor Author

👋 感谢您对 RT-Thread 的贡献！Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范，请在你的仓库中执行以下步骤运行代码格式化工作流（如果格式化CI运行失败）。 To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).

🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →
  2. 点击 Run workflow | Click Run workflow
  • 设置需排除的文件/目录（目录请以"/"结尾）
    Set files/directories to exclude (directories should end with "/")
  • 将目标分支设置为 \ Set the target branch to：drv_spi_fix
  • 设置PR number为 \ Set the PR number to：11633
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将自动推送至你的分支。
    The formatted code will be automatically pushed to your branch.

完成后，提交将自动更新至 drv_spi_fix 分支，关联的 Pull Request 也会同步更新。 Once completed, commits will be pushed to the drv_spi_fix branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们，再次感谢您的贡献！💐 If you have any questions, feel free to reach out. Thanks again for your contribution!

clangd format已经完成

@wdfk-prog

wdfk-prog commented Jul 18, 2026

Copy link
Copy Markdown
Contributor
  • 这些在h7的dma.h里面没有定义吧?
SPI6_RX_DMA_RCC,              \
SPI6_RX_DMA_IRQ,              \
SPI6_TX_DMA_RCC,              \
SPI6_TX_DMA_IRQ,              \

@moment-NEW

moment-NEW commented Jul 18, 2026

Copy link
Copy Markdown
Contributor Author
  • 这些在h7的dma.h里面没有定义吧?
SPI6_RX_DMA_RCC,              \
SPI6_RX_DMA_IRQ,              \
SPI6_TX_DMA_RCC,              \
SPI6_TX_DMA_IRQ,              \

啊对的...我还没有测试过SPI6配合DMA。而且也不能照搬F4的...我的锅。稍后我再加个commit吧

@moment-NEW

moment-NEW commented Jul 18, 2026

Copy link
Copy Markdown
Contributor Author
  • 这些在h7的dma.h里面没有定义吧?
SPI6_RX_DMA_RCC,              \
SPI6_RX_DMA_IRQ,              \
SPI6_TX_DMA_RCC,              \
SPI6_TX_DMA_IRQ,              \

啊对的...我还没有测试过SPI6配合DMA。而且也不能照搬F4的...我的锅。稍后我再加个commit吧

不过SPI6似乎只支持BDMA，看起来H7尚不支持，如果顺便修改DMA会涉及很多的驱动相关...或许需要开一个新的PR。我这段时间尝试一下修改SPI驱动吧

@moment-NEW

moment-NEW commented Jul 18, 2026

Copy link
Copy Markdown
Contributor Author
DYP 4KGMJ~~LQ0~4DW@{)X6 可以看到这个APB4和BDMA在同一个域里面... 而DMA1和DMA2不在这个域里... 所以SPI6只能用驱动尚不支持的BDMA，所以这个PR我先去掉DMA相关支持好了。我后续尝试一下修改spi_drv等使其支持BDMA

wdfk-prog
wdfk-prog approved these changes Jul 18, 2026
View reviewed changes

@wdfk-prog wdfk-prog left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wdfk-prog

wdfk-prog commented Jul 18, 2026

Copy link
Copy Markdown
Contributor
  • 这些在h7的dma.h里面没有定义吧?
SPI6_RX_DMA_RCC,              \
SPI6_RX_DMA_IRQ,              \
SPI6_TX_DMA_RCC,              \
SPI6_TX_DMA_IRQ,              \

啊对的...我还没有测试过SPI6配合DMA。而且也不能照搬F4的...我的锅。稍后我再加个commit吧

不过SPI6似乎只支持BDMA，看起来H7尚不支持，如果顺便修改DMA会涉及很多的驱动相关...或许需要开一个新的PR。我这段时间尝试一下修改SPI驱动吧

  • 现在的有把一些驱动的dma合并到dma.c进行使用api调用了,如果BDMA要支持看一下做到dma.c或者新开一个bmda.c更好

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@wdfk-prog wdfk-prog wdfk-prog approved these changes
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

BSP: STM32 BSP related with ST/STM32 BSP

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@moment-NEW @wdfk-prog