fix(federation): previous states on initial state and remove emitter #37677

ggazzo · 2025-12-02T21:07:51Z

https://rocketchat.atlassian.net/browse/FB-52

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

changeset-bot · 2025-12-02T21:07:55Z

⚠️ No Changeset found

Latest commit: 7204642

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

dionisio-bot · 2025-12-02T21:07:55Z

Looks like this PR is not ready to merge, because of the following issues:

This PR is missing the 'stat: QA assured' label
This PR is targeting the wrong base branch. It should target 7.14.0, but it targets 7.13.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

coderabbitai · 2025-12-02T21:07:58Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch chore/fed-emit

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

github-actions · 2025-12-02T21:27:35Z

📦 Docker Image Size Report

📈 Changes

Service	Current	Baseline	Change
sum of all images	1.2GiB	1.2GiB	+12MiB
rocketchat	359MiB	347MiB	+12MiB
omnichannel-transcript-service	132MiB	132MiB	+17KiB
queue-worker-service	132MiB	132MiB	+16KiB
ddp-streamer-service	126MiB	126MiB	+22KiB
account-service	113MiB	113MiB	+16KiB
stream-hub-service	111MiB	111MiB	+13KiB
presence-service	111MiB	111MiB	+21KiB
authorization-service	111MiB	111MiB	+17KiB

📊 Historical Trend

---
config:
  theme: "dark"
  xyChart:
    width: 900
    height: 400
---
xychart
  title "Image Size Evolution by Service (Last 30 Days + This PR)"
  x-axis ["11/15 22:28", "11/16 01:28", "11/17 23:50", "11/18 22:53", "11/19 23:02", "11/21 16:49", "11/24 17:34", "11/27 22:32", "11/28 19:05", "12/01 23:01", "12/02 21:57", "12/03 21:00", "12/04 18:17", "12/05 21:56", "12/05 23:24 (PR)"]
  y-axis "Size (GB)" 0 --> 0.5
  line "account-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "authorization-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "ddp-streamer-service" [0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12]
  line "omnichannel-transcript-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13]
  line "presence-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "queue-worker-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13]
  line "rocketchat" [0.36, 0.36, 0.35, 0.35, 0.35, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.35]
  line "stream-hub-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]

Statistics (last 14 days):

📊 Average: 1.5GiB
⬇️ Minimum: 1.2GiB
⬆️ Maximum: 1.6GiB
🎯 Current PR: 1.2GiB

ℹ️ About this report

This report compares Docker image sizes from this build against the develop baseline.

Tag: pr-37677
Baseline: develop
Timestamp: 2025-12-05 23:24:17 UTC
Historical data points: 14

Updated: Fri, 05 Dec 2025 23:24:17 GMT

Copilot

Pull request overview

This pull request refactors the federation-matrix package to use the SDK's built-in event emitter service instead of maintaining a local Emitter instance. The changes also improve error messages by adding contextual information.

Key Changes

Removes local Emitter instantiation and passes the SDK's eventEmitterService to event handlers instead
Updates all event handler functions to access federationSDK.eventEmitterService directly
Improves error messages in room event handlers by including roomId and userId context
Changes room name event handler to use sender field instead of state_key

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
ee/packages/federation-matrix/src/setup.ts	Removes local Emitter instantiation and unused imports, simplifies initialization
ee/packages/federation-matrix/src/events/index.ts	Updates function signatures to remove emitter parameter
ee/packages/federation-matrix/src/events/room.ts	Changes event emitter usage, switches from state_key to sender field, improves error messages
ee/packages/federation-matrix/src/events/reaction.ts	Updates to use SDK's event emitter service, removes unused imports
ee/packages/federation-matrix/src/events/ping.ts	Updates to use SDK's event emitter service
ee/packages/federation-matrix/src/events/message.ts	Updates to use SDK's event emitter service, consolidates imports
ee/packages/federation-matrix/src/events/member.ts	Updates to use SDK's event emitter service, reorganizes imports
ee/packages/federation-matrix/src/events/edu.ts	Updates to use SDK's event emitter service

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-03T17:52:13Z

ee/packages/federation-matrix/src/events/room.ts

+			throw new Error(`mapped room not found: ${roomId}`);
 		}

 		const localUserId = await Users.findOneByUsername(userId, { projection: { _id: 1 } });


The sender field in Matrix events contains the full Matrix user ID (format: @username:server.domain), but Users.findOneByUsername() expects only the username part. This will cause the user lookup to fail. Use the getUsernameServername utility function to extract the username, similar to how it's done in the room.role event handler (line 63).

Copilot · 2025-12-03T17:52:13Z

ee/packages/federation-matrix/src/events/room.ts

 			room_id: roomId,
 			content: { name },
-			state_key: userId,
+			sender: userId,


The variable name userId is misleading as it contains the full Matrix user ID from sender (format: @username:server.domain), not just a local user ID. Consider renaming to senderId or senderMatrixId for clarity, and then use getUsernameServername() to extract the actual username before calling Users.findOneByUsername().

codecov · 2025-12-05T03:03:48Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (feat/invites@fe34d35). Learn more about missing BASE report.

Additional details and impacted files

@@               Coverage Diff               @@
##             feat/invites   #37677   +/-   ##
===============================================
  Coverage                ?   54.17%           
===============================================
  Files                   ?     2638           
  Lines                   ?    50034           
  Branches                ?    11198           
===============================================
  Hits                    ?    27107           
  Misses                  ?    20781           
  Partials                ?     2146

Flag	Coverage Δ
e2e	`57.27% <ø> (?)`
e2e-api	`43.16% <ø> (?)`

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…rvice and remove Emitter dependency

…sure proper member and message reflection

ggazzo changed the title ~~refactor: remove auto-join invite capability~~ fix(federation): previous states on initial state and remove emitter Dec 2, 2025

ggazzo force-pushed the feat/invites branch from 9578ce8 to b2cc5c0 Compare December 3, 2025 17:42

ggazzo force-pushed the chore/fed-emit branch from ae0a9a2 to 88070a2 Compare December 3, 2025 17:44

ggazzo requested a review from Copilot December 3, 2025 17:46

Copilot started reviewing on behalf of ggazzo December 3, 2025 17:47 View session

Copilot finished reviewing on behalf of ggazzo December 3, 2025 17:49

Copilot AI reviewed Dec 3, 2025

View reviewed changes

ggazzo force-pushed the feat/invites branch from b2cc5c0 to 0d14b19 Compare December 3, 2025 18:49

ggazzo force-pushed the chore/fed-emit branch from 88070a2 to 32b5876 Compare December 3, 2025 20:34

ricardogarim force-pushed the feat/invites branch from dba8733 to 85183c9 Compare December 4, 2025 18:51

sampaiodiego force-pushed the feat/invites branch from 85183c9 to aa7354e Compare December 4, 2025 20:26

ggazzo force-pushed the chore/fed-emit branch 2 times, most recently from ea084df to b57caa1 Compare December 5, 2025 02:19

ggazzo force-pushed the chore/fed-emit branch 5 times, most recently from 82d2031 to 9525467 Compare December 5, 2025 21:23

ggazzo added this to the 7.14.0 milestone Dec 5, 2025

ggazzo added 2 commits December 5, 2025 20:10

refactor: update event handling to use federationSDK's eventEmitterSe…

cb69a57

…rvice and remove Emitter dependency

test: refactor end-to-end test for inviting a user from Synapse to en…

7204642

…sure proper member and message reflection

sampaiodiego force-pushed the chore/fed-emit branch from 9525467 to 7204642 Compare December 5, 2025 23:10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(federation): previous states on initial state and remove emitter #37677

fix(federation): previous states on initial state and remove emitter #37677

ggazzo commented Dec 2, 2025 •

edited

Loading

Uh oh!

changeset-bot bot commented Dec 2, 2025 •

edited

Loading

Uh oh!

dionisio-bot bot commented Dec 2, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Dec 2, 2025 •

edited

Loading

Review skipped

Other AI code review bot(s) detected

Uh oh!

github-actions bot commented Dec 2, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Dec 3, 2025

Uh oh!

Copilot AI Dec 3, 2025

Uh oh!

codecov bot commented Dec 5, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fix(federation): previous states on initial state and remove emitter #37677

Are you sure you want to change the base?

fix(federation): previous states on initial state and remove emitter #37677

Conversation

ggazzo commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Uh oh!

changeset-bot bot commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

dionisio-bot bot commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Other AI code review bot(s) detected

Uh oh!

github-actions bot commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Docker Image Size Report

📈 Changes

📊 Historical Trend

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Key Changes

Reviewed changes

Uh oh!

Copilot AI Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Dec 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ggazzo commented Dec 2, 2025 •

edited

Loading

changeset-bot bot commented Dec 2, 2025 •

edited

Loading

dionisio-bot bot commented Dec 2, 2025 •

edited

Loading

coderabbitai bot commented Dec 2, 2025 •

edited

Loading

github-actions bot commented Dec 2, 2025 •

edited

Loading

codecov bot commented Dec 5, 2025 •

edited

Loading