add bash tool result formatter#949
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
274ff62 to
3cbf8fb
Compare
9a40624 to
d0ec520
Compare
3cbf8fb to
e85c29d
Compare
e85c29d to
140401c
Compare
| # so callers pass each piece of the summary without minding separators. | ||
| # | ||
| #: (*String?) -> String | ||
| def ok_line(*parts) |
There was a problem hiding this comment.
Really nice abstraction — the doc comment calling this "the success-side twin of #error_line" is a great conceptual frame. Future readers will immediately understand how the error/success paths mirror each other.
It does sound like it was written by an AI :p but such is life these days, and it is clear
| format_unknown | ||
| end | ||
|
|
||
| TRUNCATE_LIMIT = 45 |
There was a problem hiding this comment.
Not blocking, but something to think about for the future: TRUNCATE_LIMIT and truncate are also defined in tool_use.rb (in the parallel stack). When both stacks land, that's duplicated constants and logic.
It does feel like premature optimization to put this constant in some shared abstraction before these stacks are even shipped, but at least think about where this might live, and either put it there up front or circle back after all of these merge to consolidate.

No description provided.