add todowrite tool result formatter#957
Draft
LasmarKhalifa wants to merge 1 commit into
Draft
Conversation
This was referenced Jun 16, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
LasmarKhalifa
force-pushed
the
06-16/tool-result-format-skill
branch
from
0f8e122 to
e361f02
Compare
LasmarKhalifa
force-pushed
the
06-16/tool-result-format-todowrite
branch
from
9ccb1fc to
5debb1b
Compare
This was referenced Jun 16, 2026
juniper-shopify
requested changes
Jun 17, 2026
| done = todos.count { |todo| todo[:status] == "completed" } | ||
| active = todos.find { |todo| todo[:status] == "in_progress" } | ||
| progress = "#{done}/#{todos.length} done" if todos.any? | ||
| active_label = truncate(active[:activeForm] || active[:content]) if active |
Contributor
There was a problem hiding this comment.
If a todo has status: "in_progress" but neither :activeForm nor :content, the || chain returns nil and truncate(nil) would raise. For consistency with the .to_s pattern used elsewhere:
active_label = truncate((active[:activeForm] || active[:content]).to_s) if active
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.