Templates for posts with the same title never get the slug suffix appended - #13278
Open
ntsekouras wants to merge 1 commit into
Open
Templates for posts with the same title never get the slug suffix appended#13278ntsekouras wants to merge 1 commit into
ntsekouras wants to merge 1 commit into
Conversation
…type_block_template` can never match
_wp_build_title_and_description_for_single_post_type_block_template can never match
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/65966
When a template is created for a specific post or page, _wp_build_title_and_description_for_single_post_type_block_template() is supposed to append the post slug to the computed template title when more posts share the same title, so they can be distinguished in the templates list.
That check can never match though. The second query only sets title and is merged into $default_args, which contains posts_per_page => 1, so count( $posts_with_same_title_query->posts ) > 1 is always false. This has been the case since the function was introduced in 6.1(WordPress/gutenberg#43862).
Steps to reproduce:
Create two published posts with the same title.
In the Site Editor, create a template for each of them (Templates > Add template > Single item: Post).
Both templates show the same title (Post: {title}), without the (slug) suffix.
The fix is to let the second query fetch up to two posts, same as the taxonomy variant already does with number => 2 in _wp_build_title_and_description_for_taxonomy_block_template():
The taxonomy and author variants are not affected.
Screenshots
Use of AI Tools
Generated with Fable 5 and adjusted/reviewed manually.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.