Skip to content

Templates for posts with the same title never get the slug suffix appended #13278

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ntsekouras wants to merge 3 commits into from
+187 −1
Closed

Templates for posts with the same title never get the slug suffix appended #13278

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
360dfe5
Same title check in `_wp_build_title_and_description_for_single_post_…
ntsekouras Aug 26, 2026
7b8bd1c
more tests (taxonomies)
ntsekouras Aug 26, 2026
d785c7c
add assertion messages
ntsekouras Aug 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/wp-includes/block-template-utils.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -729,7 +729,8 @@ function _wp_build_title_and_description_for_single_post_type_block_template( $p
);

$args = array(
'title' => $post_title,
'title' => $post_title,
'posts_per_page' => 2,
);
$args = wp_parse_args( $args, $default_args );

Expand Down
185 changes: 185 additions & 0 deletions tests/phpunit/tests/block-templates/buildBlockTemplateResultFromPost.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -176,6 +176,191 @@ public function test_should_not_inject_ignored_hooked_block_into_template() {
$this->assertStringNotContainsString( '<!-- wp:tests/ignored /-->', $template->content );
}

/**
* @ticket 65966
*/
public function test_should_append_post_slug_to_title_when_posts_share_the_same_title() {
self::factory()->post->create(
array(
'post_title' => 'Same Title',
'post_name' => 'first-post',
)
);
self::factory()->post->create(
array(
'post_title' => 'Same Title',
'post_name' => 'second-post',
)
);

$first_template_post = self::factory()->post->create_and_get(
array(
'post_type' => 'wp_template',
'post_name' => 'single-post-first-post',
'post_title' => 'single-post-first-post',
'post_content' => 'Content',
'post_excerpt' => '',
'tax_input' => array(
'wp_theme' => array(
self::TEST_THEME,
),
),
)
);
wp_set_post_terms( $first_template_post->ID, self::TEST_THEME, 'wp_theme' );

$second_template_post = self::factory()->post->create_and_get(
array(
'post_type' => 'wp_template',
'post_name' => 'single-post-second-post',
'post_title' => 'single-post-second-post',
'post_content' => 'Content',
'post_excerpt' => '',
'tax_input' => array(
'wp_theme' => array(
self::TEST_THEME,
),
),
)
);
wp_set_post_terms( $second_template_post->ID, self::TEST_THEME, 'wp_theme' );

$first_template = _build_block_template_result_from_post( $first_template_post );
$second_template = _build_block_template_result_from_post( $second_template_post );

$this->assertNotWPError( $first_template, 'Building the template for the first post should not return an error.' );
$this->assertSame( 'Post: Same Title (first-post)', $first_template->title, 'The title of the first post template should be suffixed with the post slug.' );
$this->assertNotWPError( $second_template, 'Building the template for the second post should not return an error.' );
$this->assertSame( 'Post: Same Title (second-post)', $second_template->title, 'The title of the second post template should be suffixed with the post slug.' );
}

/**
* @ticket 65966
*/
public function test_should_not_append_post_slug_to_title_when_post_title_is_unique() {
self::factory()->post->create(
array(
'post_title' => 'Unique Title',
'post_name' => 'unique-post',
)
);

$template_post = self::factory()->post->create_and_get(
array(
'post_type' => 'wp_template',
'post_name' => 'single-post-unique-post',
'post_title' => 'single-post-unique-post',
'post_content' => 'Content',
'post_excerpt' => '',
'tax_input' => array(
'wp_theme' => array(
self::TEST_THEME,
),
),
)
);
wp_set_post_terms( $template_post->ID, self::TEST_THEME, 'wp_theme' );

$template = _build_block_template_result_from_post( $template_post );

$this->assertNotWPError( $template, 'Building the template should not return an error.' );
$this->assertSame( 'Post: Unique Title', $template->title, 'The template title should not be suffixed with the post slug when the post title is unique.' );
}

/**
* @ticket 65966
*/
public function test_should_append_term_slug_to_title_when_terms_share_the_same_name() {
self::factory()->term->create(
array(
'taxonomy' => 'post_tag',
'name' => 'Same Name',
'slug' => 'first-tag',
)
);
self::factory()->term->create(
array(
'taxonomy' => 'post_tag',
'name' => 'Same Name',
'slug' => 'second-tag',
)
);

$first_template_post = self::factory()->post->create_and_get(
array(
'post_type' => 'wp_template',
'post_name' => 'tag-first-tag',
'post_title' => 'tag-first-tag',
'post_content' => 'Content',
'post_excerpt' => '',
'tax_input' => array(
'wp_theme' => array(
self::TEST_THEME,
),
),
)
);
wp_set_post_terms( $first_template_post->ID, self::TEST_THEME, 'wp_theme' );

$second_template_post = self::factory()->post->create_and_get(
array(
'post_type' => 'wp_template',
'post_name' => 'tag-second-tag',
'post_title' => 'tag-second-tag',
'post_content' => 'Content',
'post_excerpt' => '',
'tax_input' => array(
'wp_theme' => array(
self::TEST_THEME,
),
),
)
);
wp_set_post_terms( $second_template_post->ID, self::TEST_THEME, 'wp_theme' );

$first_template = _build_block_template_result_from_post( $first_template_post );
$second_template = _build_block_template_result_from_post( $second_template_post );

$this->assertNotWPError( $first_template, 'Building the template for the first term should not return an error.' );
$this->assertSame( 'Tag: Same Name (first-tag)', $first_template->title, 'The title of the first term template should be suffixed with the term slug.' );
$this->assertNotWPError( $second_template, 'Building the template for the second term should not return an error.' );
$this->assertSame( 'Tag: Same Name (second-tag)', $second_template->title, 'The title of the second term template should be suffixed with the term slug.' );
}

/**
* @ticket 65966
*/
public function test_should_not_append_term_slug_to_title_when_term_name_is_unique() {
self::factory()->term->create(
array(
'taxonomy' => 'category',
'name' => 'Unique Category',
'slug' => 'unique-category',
)
);

$template_post = self::factory()->post->create_and_get(
array(
'post_type' => 'wp_template',
'post_name' => 'category-unique-category',
'post_title' => 'category-unique-category',
'post_content' => 'Content',
'post_excerpt' => '',
'tax_input' => array(
'wp_theme' => array(
self::TEST_THEME,
),
),
)
);
wp_set_post_terms( $template_post->ID, self::TEST_THEME, 'wp_theme' );

$template = _build_block_template_result_from_post( $template_post );

$this->assertNotWPError( $template, 'Building the template should not return an error.' );
$this->assertSame( 'Category: Unique Category', $template->title, 'The template title should not be suffixed with the term slug when the term name is unique.' );
}

/**
* @ticket 59646
* @ticket 60506
Expand Down
Loading