feat(tui): make dialog and sidebar overlay backgrounds themeable#25103
feat(tui): make dialog and sidebar overlay backgrounds themeable#25103jnslmk wants to merge 2 commits intoanomalyco:devfrom
Conversation
- Add backgroundDialogOverlay and backgroundSidebarOverlay theme properties - Both default to semi-transparent black (150 and 70 alpha) - backgroundDialogOverlay replaces hardcoded RGBA(0,0,0,150) in dialog.tsx - backgroundSidebarOverlay replaces hardcoded RGBA(0,0,0,70) in session/index.tsx - Add tests for default and custom overlay values
58b571a to
a89f75e
Compare
|
The following comment was made by an LLM, it may be inaccurate: Potential Duplicates FoundBased on the search results, there are several related PRs addressing similar overlay theming issues:
These PRs appear to be addressing the same or very similar issues—making dialog and sidebar overlay backgrounds themeable instead of using hardcoded colors. You should check the status and implementation details of PR #23024 in particular, as it seems to be the most recent related attempt. |
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
The other approaches derive the overlay color from existing theme colors but still include a fixed alpha value. The problem I'm addressing in the linked issue does not get solved by them. An alternative approach could be to handle the RGB and alpha channels separately and allow only theming the RGB and/or alpha part of the the color. |
Issue for this PR
Closes #25102
Type of change
What does this PR do?
Added
backgroundDialogOverlayandbackgroundSidebarOverlaytheme properties to allow customization of overlay backgrounds instead of using hardcoded RGBA values.Hardcoded overlay colors (150 and 70 alpha black) in
dialog.tsxandsession/index.tsxprevented theme customization. Users couldn't adjust overlay appearance through themes.How did you verify your code works?
Screenshots / recordings
Checklist