Skip to content

AVRO-4162: [csharp] Fix AvroDecimal.CompareTo for values with different scales#3744

Merged
RyanSkraba merged 2 commits intoapache:mainfrom
ChristophMajcenAtXxxlutz:fix/dotnetAvroDecimalCompare
May 2, 2026
Merged

AVRO-4162: [csharp] Fix AvroDecimal.CompareTo for values with different scales#3744
RyanSkraba merged 2 commits intoapache:mainfrom
ChristophMajcenAtXxxlutz:fix/dotnetAvroDecimalCompare

Conversation

@ChristophMajcenAtXxxlutz
Copy link
Copy Markdown
Contributor

@ChristophMajcenAtXxxlutz ChristophMajcenAtXxxlutz commented Apr 27, 2026

What is the purpose of the change

Fixes AVRO-4162

Verifying this change

This change added tests and can be verified as follows:

  • Added tests in AvroDecimalTests that verify correct behaviour

Documentation

  • Does this pull request introduce a new feature? no

@github-actions github-actions Bot added the C# label Apr 27, 2026
Comment thread lang/csharp/src/apache/test/AvroDecimalTest.cs
Comment thread lang/csharp/src/apache/main/AvroDecimal.cs
@RyanSkraba RyanSkraba merged commit 5af5735 into apache:main May 2, 2026
8 checks passed
@RyanSkraba
Copy link
Copy Markdown
Contributor

Cherry-picked to branch-1.12.

RyanSkraba pushed a commit that referenced this pull request May 2, 2026
…nt scales (#3744)

* fix(AVRO-4162): dotnet AvroDecimal.CompareTo for values with different scale

* fix(AVRO-4162): Make tests not culture-sensitive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants