Skip to content

AVRO-4162: [csharp] Fix AvroDecimal.CompareTo for values with different scales #3744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ChristophMajcenAtXxxlutz wants to merge 2 commits into
base: main
Choose a base branch
from
+44 −22
Open

AVRO-4162: [csharp] Fix AvroDecimal.CompareTo for values with different scales #3744

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
176d24b
fix(AVRO-4162): dotnet AvroDecimal.CompareTo for values with differen…
ChristophMajcenAtXxxlutz Apr 27, 2026
b249378
fix(AVRO-4162): Make tests not culture-sensitive
ChristophMajcenAtXxxlutz Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions lang/csharp/src/apache/main/AvroDecimal.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1140,20 +1140,14 @@ public int CompareTo(AvroDecimal other)
var unscaledValueCompare = UnscaledValue.CompareTo(other.UnscaledValue);
var scaleCompare = Scale.CompareTo(other.Scale);

// if both are the same value, return the value
if (unscaledValueCompare == scaleCompare)
{
return unscaledValueCompare;
}

// if the scales are both the same return unscaled value
if (scaleCompare == 0)
{
return unscaledValueCompare;
}

var scaledValue = BigInteger.Divide(UnscaledValue, BigInteger.Pow(new BigInteger(10), Scale));
var otherScaledValue = BigInteger.Divide(other.UnscaledValue, BigInteger.Pow(new BigInteger(10), other.Scale));
var scaledValue = (decimal) UnscaledValue / (decimal) Math.Pow(10, Scale);
var otherScaledValue = (decimal) other.UnscaledValue / (decimal) Math.Pow(10, other.Scale);

return scaledValue.CompareTo(otherScaledValue);
}
Expand Down
56 changes: 42 additions & 14 deletions lang/csharp/src/apache/test/AvroDecimalTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,29 +16,32 @@
* limitations under the License.
*/

using System.Globalization;
using NUnit.Framework;

namespace Avro.test
{
[TestFixture]
class AvroDecimalTest
{
[TestCase(1)]
[TestCase(1000)]
[TestCase(10.10)]
[TestCase(0)]
[TestCase(0.1)]
[TestCase(0.01)]
[TestCase(-1)]
[TestCase(-1000)]
[TestCase(-10.10)]
[TestCase(-0.1)]
[TestCase(-0.01)]
public void TestAvroDecimalToString(decimal value)
//Use strings as parameters as otherwise doubles will be used intermediately by C# and scale will be lost in this process
Comment thread
ChristophMajcenAtXxxlutz marked this conversation as resolved.
[TestCase("1")]
[TestCase("1000")]
[TestCase("10.10")]
[TestCase("0")]
[TestCase("0.1")]
[TestCase("0.01")]
[TestCase("-1")]
[TestCase("-1000")]
[TestCase("-10.10")]
[TestCase("-0.1")]
[TestCase("-0.01")]
public void TestAvroDecimalToString(string value)
{
var valueString = value.ToString();
var valueDecimal = decimal.Parse(value, CultureInfo.InvariantCulture);
var valueString = valueDecimal.ToString();

var avroDecimal = new AvroDecimal(value);
var avroDecimal = new AvroDecimal(valueDecimal);
var avroDecimalString = avroDecimal.ToString();

Assert.AreEqual(valueString, avroDecimalString);
Expand All @@ -63,5 +66,30 @@ public void TestHighPrecisionAvroDecimalToString()

Assert.AreEqual(valueString, avroDecimalString);
}

//Use strings as parameters as otherwise doubles will be used intermediately by C# and scale will be lost in this process
[TestCase("0", "0", ExpectedResult = 0)]
[TestCase("1", "0", ExpectedResult = 1)]
[TestCase("0", "1", ExpectedResult = -1)]
[TestCase("1.0", "1.0", ExpectedResult = 0)]
[TestCase("1.0", "1", ExpectedResult = 0)]
[TestCase("1", "1.0", ExpectedResult = 0)]
[TestCase("1.0", "0", ExpectedResult = 1)]
[TestCase("0", "1.0", ExpectedResult = -1)]
[TestCase("-0.5", "-1.0", ExpectedResult = 1)]
[TestCase("-1.0", "-0.5", ExpectedResult = -1)]
[TestCase("0.1", "0.01", ExpectedResult = 1)]
[TestCase("0.01", "0.1", ExpectedResult = -1)]
[TestCase("-0.1", "-0.01", ExpectedResult = -1)]
[TestCase("-0.01", "-0.1", ExpectedResult = 1)]
public int TestAvroDecimalCompareTo(string left, string right)
{
var leftDecimal = decimal.Parse(left, CultureInfo.InvariantCulture);
var rightDecimal = decimal.Parse(right, CultureInfo.InvariantCulture);
var leftAvroDecimal = new AvroDecimal(leftDecimal);
var rightAvroDecimal = new AvroDecimal(rightDecimal);

return leftAvroDecimal.CompareTo(rightAvroDecimal);
}
}
}
Loading