[ErrorProne] Enable UnnecessaryLongToIntConversion check

[stankiewicz]

Enables UnnecessaryLongToIntConversion error-prone check in BeamModulePlugin.groovy. This check prevents instances where a longorLongis needlessly converted to anintwhen used as an argument for a method parameter that evaluates to along`.

---

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request improves code quality and robustness by enabling the UnnecessaryLongToIntConversion ErrorProne check. This check helps prevent potential data loss or unexpected behavior that can arise from implicit or unnecessary conversions of long values to int when a long is expected. The changes include removing the check from the suppression list and applying necessary fixes to code identified by this new check.

Highlights

• ErrorProne Check Enabled: The UnnecessaryLongToIntConversion ErrorProne check has been enabled in BeamModulePlugin.groovy to identify and prevent redundant type conversions.
• Type Conversion Fixes: Several instances of unnecessary long to int conversions have been corrected across various modules, including Dataflow worker streaming configuration, Samza metric tests, and Pulsar IO integration tests.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
  • Removed UnnecessaryLongToIntConversion from the list of suppressed ErrorProne checks.
• runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/streaming/config/StreamingEngineComputationConfigFetcher.java
  • Removed an unnecessary intValue() call when setting maxWorkItemCommitBytes.
• runners/samza/src/test/java/org/apache/beam/runners/samza/metrics/TestSamzaRunnerWithTransformMetrics.java
  • Updated assertEquals calls to use longValue() instead of intValue() for cacheSize comparisons.
• runners/samza/src/test/java/org/apache/beam/runners/samza/metrics/TestSamzaTransformMetricsRegistry.java
  • Updated assertEquals calls to use longValue() instead of intValue() for cacheSize comparisons.
• sdks/java/io/pulsar/src/test/java/org/apache/beam/sdk/io/pulsar/PulsarIOIT.java
  • Removed an unnecessary explicit (int) cast for recordsCount in an assertEquals call.

Activity

• No human activity has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[github-actions]

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

[stankiewicz]

/gemini review

[gemini-code-assist]

Code Review

The pull request successfully enables the UnnecessaryLongToIntConversion error-prone check. The changes correctly address instances where long values were unnecessarily converted to int, improving type safety and adhering to the newly enabled check. All modifications are direct improvements that align with the goal of preventing potential data loss and enhancing code quality.

[stankiewicz]

Run Java_GCP_IO_Direct PreCommit

[stankiewicz]

Run Java_GCP_IO_Direct PreCommit