Skip to content

[ErrorProne] Enable UnnecessaryLongToIntConversion check #37783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stankiewicz wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −7
Open

[ErrorProne] Enable UnnecessaryLongToIntConversion check #37783

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1580,7 +1580,6 @@ class BeamModulePlugin implements Plugin<Project> {
"NullableWildcard",
"StringCharset",
"SuperCallToObjectMethod",
"UnnecessaryLongToIntConversion",
"UnusedVariable",
// intended suppressions emerged in newer protobuf versions
"AutoValueBoxedValues",
Expand Down
2 changes: 1 addition & 1 deletion ...eam/runners/dataflow/worker/streaming/config/StreamingEngineComputationConfigFetcher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ private StreamingGlobalConfig createPipelineConfig(StreamingConfigTask config) {
if (config.getMaxWorkItemCommitBytes() != null
&& config.getMaxWorkItemCommitBytes() > 0
&& config.getMaxWorkItemCommitBytes() <= Integer.MAX_VALUE) {
operationalLimits.setMaxWorkItemCommitBytes(config.getMaxWorkItemCommitBytes().intValue());
operationalLimits.setMaxWorkItemCommitBytes(config.getMaxWorkItemCommitBytes());
}

if (config.getOperationalLimits() != null) {
Expand Down
4 changes: 2 additions & 2 deletions .../test/java/org/apache/beam/runners/samza/metrics/TestSamzaRunnerWithTransformMetrics.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,7 +245,7 @@ public void testSamzaInputAndOutputMetricOp() {
// Latency must be positive
assertTrue(latency.getSnapshot().getAverage() > 0);
// Cache size must be 0
assertEquals(0, cacheSize.getValue().intValue());
assertEquals(0L, cacheSize.getValue().longValue());
}

@Test
Expand Down Expand Up @@ -318,6 +318,6 @@ public void testSamzaInputAndOutputGBKMetricOp() {
// Latency must be positive
assertTrue(latency.getSnapshot().getAverage() > 0);
// Cache size must be 0
assertEquals(0, cacheSize.getValue().intValue());
assertEquals(0L, cacheSize.getValue().longValue());
}
}
4 changes: 2 additions & 2 deletions ...rc/test/java/org/apache/beam/runners/samza/metrics/TestSamzaTransformMetricsRegistry.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ public void testSamzaTransformMetricsRegistryForNonShuffleOperators() {
.get("dummy-pvalue.out")
.containsKey(watermarkMessage.getTimestamp()));
// Cache size must be 0
assertEquals(0, cacheSize.getValue().intValue());
assertEquals(0L, cacheSize.getValue().longValue());
}

@Test
Expand Down Expand Up @@ -186,6 +186,6 @@ public Instant maxTimestamp() {
// Check the latency metric is same
assertTrue(1000 == latency.getSnapshot().getAverage());
// Cache size must be 0
assertEquals(0, cacheSize.getValue().intValue());
assertEquals(0L, cacheSize.getValue().longValue());
}
}
2 changes: 1 addition & 1 deletion sdks/java/io/pulsar/src/test/java/org/apache/beam/sdk/io/pulsar/PulsarIOIT.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ public void testReadFromSimpleTopic() throws PulsarClientException {
break;
}
}
assertEquals(inputsMock.size(), (int) recordsCount);
assertEquals(inputsMock.size(), recordsCount);
}

@Test
Expand Down
Loading