[UUID 5/8] UUID aggregation, group-by and distinct#18873
Open
xiangfu0 wants to merge 4 commits into
Open
Conversation
This was referenced Jun 29, 2026
6120bc9 to
478757f
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #18873 +/- ##
============================================
- Coverage 64.89% 64.86% -0.03%
Complexity 1347 1347
============================================
Files 3398 3399 +1
Lines 212550 213491 +941
Branches 33503 33709 +206
============================================
+ Hits 137927 138488 +561
- Misses 63481 63802 +321
- Partials 11142 11201 +59
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
b5e8bc6 to
64cb941
Compare
4a78138 to
dac264f
Compare
Part 2/8 of splitting apache#18140 (logical UUID type). Rebased onto master (now includes the merged apache#18869 type foundation); stacked on 92a0d98. Downstream references use the UuidKey class merged in apache#18869.
Part 3/8 of splitting apache#18140 (logical UUID type). Rebased onto latest master; stacked on uuid-split/02-ingest-storage. Downstream references use the UuidKey class merged in apache#18869.
Part 4/8 of splitting apache#18140 (logical UUID type). Rebased onto latest master; stacked on uuid-split/03-result-rendering. Downstream references use the UuidKey class merged in apache#18869.
Part 5/8 of splitting apache#18140 (logical UUID type). Rebased onto latest master; stacked on uuid-split/04-sse-predicates-cast. Downstream references use the UuidKey class merged in apache#18869.
dac264f to
c5f4959
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
UUID-aware aggregation and grouping.
Changes
DISTINCTCOUNT,DISTINCTCOUNTHLL/HLLPLUS/THETASKETCH/CPCSKETCH/ULL/BITMAP,IntegerTupleSketch,ANY_VALUEUuidToIdMap,BytesDistinctTable,NonScanBasedAggregationOperatorEnables
GROUP BY uuidCol,DISTINCT uuidCol,DISTINCTCOUNT*(uuidCol).Depends on
#18869 and #18871 (
ColumnDataType.UUID).About this PR / how to review
This is part 5 of 8 splitting #18140 (first-class logical
UUIDtype) into layered PRs, as requested there.The split is enabled by the v1 design:
DataType.UUIDhas stored typeBYTES, so most paths handle it automatically; each PR adds explicit UUID semantics to one subsystem. Head branch lives onxiangfu0/pinot.This PR is stacked on #18872 (branch
uuid-split/04-sse-predicates-cast). Because GitHub PRs to apache must base onmaster, the Files-changed tab is cumulative (it includes layers 1–5) until the PRs below it merge. Review the commit titled[UUID 5/8] UUID aggregation, group-by and distinct— that is this layer's change. Each parent merge shrinks this diff after a rebase.Full stack (merge bottom → top)
After #18869 lands, PRs 2/4/7 (#18870, #18872, #18875) only depend on it and can be reviewed in parallel; PRs 5/6 (#18873, #18874) also need #18871; PR 8 (#18876) needs #18874.
Full feature description, v1 design contract, scope exclusions, and benchmark numbers: #18140.