[UUID 6/8] UUID multi-stage engine (planner + runtime)#18874
Open
xiangfu0 wants to merge 5 commits into
Open
Conversation
This was referenced Jun 29, 2026
7a7cf63 to
22f38d3
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #18874 +/- ##
============================================
- Coverage 64.81% 64.79% -0.02%
Complexity 1347 1347
============================================
Files 3396 3399 +3
Lines 212503 213512 +1009
Branches 33484 33703 +219
============================================
+ Hits 137732 138351 +619
- Misses 63610 63932 +322
- Partials 11161 11229 +68
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
bdd6933 to
69c36b3
Compare
Part 2/8 of splitting apache#18140 (logical UUID type). Rebased onto master (now includes the merged apache#18869 type foundation); stacked on 5a451fa. Downstream references use the UuidKey class merged in apache#18869.
Part 3/8 of splitting apache#18140 (logical UUID type). Rebased onto master (now includes the merged apache#18869 type foundation); stacked on uuid-split/02-ingest-storage. Downstream references use the UuidKey class merged in apache#18869.
Part 4/8 of splitting apache#18140 (logical UUID type). Rebased onto master (now includes the merged apache#18869 type foundation); stacked on uuid-split/03-result-rendering. Downstream references use the UuidKey class merged in apache#18869.
Part 5/8 of splitting apache#18140 (logical UUID type). Rebased onto master (now includes the merged apache#18869 type foundation); stacked on uuid-split/04-sse-predicates-cast. Downstream references use the UuidKey class merged in apache#18869.
Part 6/8 of splitting apache#18140 (logical UUID type). Rebased onto master (now includes the merged apache#18869 type foundation); stacked on uuid-split/05-agg-groupby-distinct. Downstream references use the UuidKey class merged in apache#18869.
69c36b3 to
763c96a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Multi-stage (v2) engine support for UUID.
Changes
expressions.protoUUID / UUID_ARRAY enum values + planner type resolution, Rex parsing, proto serde,TypeFactoryHashJoinOperator/EnrichedHashJoinOperator+UuidLookupTable(LookupTable.normalizeKey),OneUuidKeyGroupIdGenerator,ServerPlanRequestUtilsEnables
UUID equi-joins and group-by in the multi-stage engine.
Depends on
#18869 and #18871.
About this PR / how to review
This is part 6 of 8 splitting #18140 (first-class logical
UUIDtype) into layered PRs, as requested there.The split is enabled by the v1 design:
DataType.UUIDhas stored typeBYTES, so most paths handle it automatically; each PR adds explicit UUID semantics to one subsystem. Head branch lives onxiangfu0/pinot.This PR is stacked on #18873 (branch
uuid-split/05-agg-groupby-distinct). Because GitHub PRs to apache must base onmaster, the Files-changed tab is cumulative (it includes layers 1–6) until the PRs below it merge. Review the commit titled[UUID 6/8] UUID multi-stage engine (planner + runtime)— that is this layer's change. Each parent merge shrinks this diff after a rebase.Full stack (merge bottom → top)
After #18869 lands, PRs 2/4/7 (#18870, #18872, #18875) only depend on it and can be reviewed in parallel; PRs 5/6 (#18873, #18874) also need #18871; PR 8 (#18876) needs #18874.
Full feature description, v1 design contract, scope exclusions, and benchmark numbers: #18140.